Closed
Bug 1039976
Opened 10 years ago
Closed 10 years ago
Improve TypeObjectDispatch with one case
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla34
People
(Reporter: h4writer, Assigned: h4writer)
Details
Attachments
(1 file)
|
2.21 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
For MTypeObjectDispatch's with 1 case we generate: > 0xb793e9b1: mov 0x4(%ebp),%edx > 0xb793e9b4: cmp $0xb512ca40,%edx > 0xb793e9ba: je 0xb793e9c6 > 0xb793e9c0: jmp 0xb793f16a > 0xb793e9c6: ... Just like we do in "guardObjectType", we can decide to flip the cmp/je. That way we can remove a jump (if the block we are jumping to is the next block): > 0xb793e9b1: mov 0x4(%ebp),%edx > 0xb793e9b4: cmp $0xb512ca40,%edx > 0xb793e9ba: jne 0xb793f164 > 0xb793e9c0: ... This happens in deltablue. No major gains though.
|
Assignee | |
Comment 1•10 years ago
|
||
Assignee: nobody → hv1989
Attachment #8457855 -
Flags: review?(jdemooij)
|
||
Updated•10 years ago
|
Attachment #8457855 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/099c3edf515a
https://hg.mozilla.org/mozilla-central/rev/099c3edf515a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
You need to log in
before you can comment on or make changes to this bug.
Description
•