Closed
Bug 1040156
Opened 10 years ago
Closed 10 years ago
Update welcome.webmaker.org text with the winning variations
Categories
(Webmaker Graveyard :: Metrics, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adam, Assigned: adam)
References
Details
Attachments
(2 files)
Based on the results of Bug 1032224
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #8458091 -
Flags: review?(aki)
Updated•10 years ago
|
Attachment #8458091 -
Flags: review?(aki) → review+
Comment 2•10 years ago
|
||
Comment on attachment 8458091 [details] [review] https://github.com/mozilla/webmaker-landing-pages/pull/16 Oops I accidentally R'ed wrong. R-, leaving comments on the PR
Attachment #8458091 -
Flags: review+ → review-
Updated•10 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
Attachment #8458091 -
Flags: review- → review?
Assignee | ||
Updated•10 years ago
|
Attachment #8458091 -
Flags: review? → review?(aki)
Updated•10 years ago
|
Attachment #8458091 -
Flags: review?(aki) → review+
Comment 3•10 years ago
|
||
Commits pushed to master at https://github.com/mozilla/webmaker-landing-pages https://github.com/mozilla/webmaker-landing-pages/commit/8edfe333c13164bebcc41e99270dbfb3a9df6c91 Fix Bug 1040156 https://github.com/mozilla/webmaker-landing-pages/commit/aba0e3e84afd4397b4c0fa0e60329ce4095df265 Merge pull request #16 from adamlofting/bug1040156 Fix Bug 1040156 - update text based on winning optimizely experiment
Updated•10 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•10 years ago
|
||
@Aki: What's the process to push this to prod?
Flags: needinfo?(aki)
Comment 5•10 years ago
|
||
:adam - we just merge the master branch into production. So: - git checkout production - git merge master - git push mozilla production I think anyone with commit access can do this
Flags: needinfo?(aki)
Comment 6•10 years ago
|
||
For posterity's sake—I created a deploy PR and had Adam take a once-over on staging just to triple-check that everything was ready for prime-time.
Attachment #8460300 -
Flags: review+
You need to log in
before you can comment on or make changes to this bug.
Description
•