Closed Bug 104052 Opened 23 years ago Closed 23 years ago

LRE stylesheets are cool

Categories

(Core :: XSLT, defect)

Product:
Core
Component:
XSLT
Platform:
Other
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: sicking, Assigned: sicking)

References

(
URL
)

Details

Attachments

(3 files, 1 obsolete file)

testcase xsl
178 bytes, text/xml
Details
testcase xml
150 bytes, text/xml
Details
addresses comments from peterv
12.45 KB, patch
sicking
: review+
brendan
: superreview+
Details | Diff | Splinter Review 
patch that implements lre stylesheets are coming up...
just to beat Pike to it... Some of this code is sub-optimal until ns-doom has 
landed
Status: NEW → ASSIGNED
Depends on: 76070
*** Bug 104789 has been marked as a duplicate of this bug. ***
Comment on attachment 52905 [details] [diff] [review]
here goes...

Rename processTopLevel (to processStylesheet or something better), move "stylesheet" and "transform" into Names.*. With those changes, r=peterv.
Attachment #52905 - Flags: review+
Attachment #52905 - Attachment is obsolete: true
Comment on attachment 53581 [details] [diff] [review]
addresses comments from peterv

rs=brendan@mozilla.org

Code looks ok (prevailing style suppresses out of memory errors, not sure that
matters in practice).

The Map and NamedMap hash tables will perform poorly under load.  Use xpcom/ds/pldhash.h as
their implementation basis instead.
/be
Attachment #53581 - Flags: superreview+
checked in

Thanks for reviews!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
works fine. verifying
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: