1040554 - The size of the datetime items in add event view are not correct

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Evan Tseng [:evanxd]]

Attachment: datetime-items-too-big.png

Please refer to the attachment to see the issue.

Comment 1

[Miller Medeiros [:millermedeiros]]

Master or 2.0?

Comment 2

[Eric Chang [:ericcc] [:echang]]

Reproduced on my devices

Flame v2.1 master
Gecko     https://hg.mozilla.org/mozilla-central/rev/e9cdcf646d1c
BuildID   20140720160202
Version   33.0a1
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Flame v2.0 aurora
Gaia      8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c6f9f0396153
BuildID   20140720160208
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Comment 3

[Evan Tseng [:evanxd]]

Hi Miller,

It could be reproduced on current master and 2.0.

Gaia version:
master: ecca261792527faa7a769145f1f854f77336c064
2.0: b9d19011123487009c80d1200937652d58c434a0

Comment 4

[Miller Medeiros [:millermedeiros]]

if it's on 2.0 it should be a blocker in my opinion

Comment 5

[Miller Medeiros [:millermedeiros]]

https://github.com/mozilla-b2g/gaia/commit/7015e7b82c7f8550bfaaec25a14ecd5a0dd35503 is the first bad commit. Regression introduced by Bug 1036147

Comment 6

[Tony Chung [:tchung]]

Attachment: screenshot

Reproduced on 2.0 build on Flame.   See screenshot.

Gaia      8cb1a949f2e9650bb2c5598e78a6f24a58bbaf97
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/c6f9f0396153
BuildID   20140720160208
Version   32.0a2
ro.build.version.incremental=109
ro.build.date=Mon Jun 16 16:51:29 CST 2014
B1TC00011220

Comment 7

[Evan Tseng [:evanxd]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22004

Comment 8

[Evan Tseng [:evanxd]]

Comment on attachment 8459866 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22004

Hi Miller,

Could you help to review the patch?

Thanks.

Comment 9

[Miller Medeiros [:millermedeiros]]

Comment on attachment 8459866 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22004

LGTM, basically the same thing as Clock app does.

Comment 10

[Evan Tseng [:evanxd]]

Thanks, Miller.

Comment 11

[Evan Tseng [:evanxd]]

master: 3078ac2ebdf8b4af42136f3943b32b8f4ce460b0

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/91986777d0942b63e37fbfeec19d69d6176d6d74

Comment 13

[Edward Chen[:edchen]]

[Environment]
Gaia      3584b2723412ed3299c6761f465885d80651c87e
Gecko     https://hg.mozilla.org/mozilla-central/rev/e7806c9c83f3
BuildID   20140820160201
Version   34.0a1
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014


[Result]
PASS

Comment 14

[Paladin]

This issue has been verified successfully on Flame 2.0

See attachment: Verify_image.png
Reproducing rate: 0/5
FLame 2.0 build:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141202000201
Version         32.0

Comment 15

[Paladin]

Attachment: Verify_image.png