Closed Bug 1040601 Opened 10 years ago Closed 6 years ago

In month view , there is an empty space at the end.

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Calendar
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: swathiks115, Unassigned)

Details

(Whiteboard: [LibGLA,DEV, B] )

Attachments

(2 files, 2 obsolete files)

whitespace.patch
509 bytes, patch
harly
: ui-review-
Details | Diff | Splinter Review
cal_whitespace.png
30.61 KB, image/png
Details 
      No description provided.
Attached image EmptySpace In MonthView (obsolete) — 
Flags: needinfo?(hhsu)

    
  
Whiteboard: [LibGLA,DEV, B]

    
    

    
  
Hi Stephany,
On what device did you observe the empty space in calendar? Previously I observed on Nexus 4 and have the same problem. Therefore, I filed on bug 1029322 addressing this.
Flags: needinfo?(hhsu)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        EmptySpace.patch (obsolete)
        — 
          — Splinter Review
      

    


  
Hi

I have attached patch for this issue.I think with this patch issue will be resolved. Please check.

        Attachment #8458496 -
        Attachment is obsolete: true

        Attachment #8458539 -
        Flags: ui-review?(hhsu)

        Attachment #8458539 -
        Flags: review?(gaye)

    
    

    
  
I checked the path in Nexus 4 with following build and it is working fine.
i.e the gap is removed.
Device: Mako (nexus 4)
Platform : 33.0a1
Build Identifier: 20140715124800

I too think that the bug is a duplicate of bug 1029322

    
    

    
  
Hi Swathiks,
Sorry to have typed your name incorrectly. About the patch, could you do a pull request like bug 992728 comment 15? It would be easier for me to run the patch and do a review this way. Thanks

    
    

    
  
Comment on attachment 8458539 [details] [diff] [review]
EmptySpace.patch

Hi Swathiks,
After reviewing the patch, basically it looks good. Just one minor thing is that it seems that the left & right margin of the month is different, and it seems that the right margin is bigger than the right, could you fix that?

        Attachment #8458539 -
        Flags: ui-review?(hhsu) → ui-review-

    
    

    
  
Okay, I will check this issue.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        whitespace.patch
        — 
          — Splinter Review
      

    


  
Hi, 
  I have attached patch. Now both left and right margin are same. Please check.

        Attachment #8458539 -
        Attachment is obsolete: true

        Attachment #8458539 -
        Flags: review?(gaye)

        Attachment #8467587 -
        Flags: ui-review?(hhsu)

    
    

    
  

      
      
      
      

        Attached image
          
        cal_whitespace.png
        — 
      

    


  
Hi,
  cal_whitespace.png is the screenshot for latest change. Please refer attachment.

Thanks.

    
    

    
  
Hi,
I have tested the patch on my nexus 4, it still seems to be the same that the right margin in bigger than the left. I've tried to adjust the value on the patch, and it seems that the margin is almost the same on both sides if I changed to width: 14.06%.

    
  

        Attachment #8467587 -
        Flags: ui-review?(hhsu) → ui-review-

    
    

    
  
Firefox OS is not being worked on
Status: UNCONFIRMED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: