Closed Bug 1040747 Opened 10 years ago Closed 10 years ago

Modify erase command to use the new factoryReset

Categories

(Firefox OS Graveyard :: FindMyDevice, defect)

Product:
Firefox OS Graveyard
Component:
FindMyDevice
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed, b2g-v2.1 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S6 (18july)
Project Flags:
blocking-b2g 2.0+
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed
b2g-v2.1 --- fixed

People

(Reporter: mgoodwin, Assigned: jhirsch)

References

Details

Attachments

(2 files, 1 obsolete file)

Github PR 21943 - updated patch against master (lint error fixed)
46 bytes, text/x-github-pull-request
fabrice
: review+
Details | Review
Github PR 21938 - v2.0 pull request with jslint fix
46 bytes, text/x-github-pull-request
Details | Review 
We have a new method of erasing data which works around various issues encountered in FindMyDevice Erase. See bug 10037212.

commands.js needs updating to reflect the new usage and new tests need writing to ensure the new method is used.
+ing this.
blocking-b2g: --- → 2.0+
Comment on attachment 8458759 [details] [review]
Modify erase command to use the new factoryReset - command changes and a test

r=me with the change we discussed on irc
Attachment #8458759 - Flags: review?(arthur.chen) → review+
As discussed on IRC, I've opened a PR of :mgoodwin's commit against 2.0:

https://github.com/mozilla-b2g/gaia/pull/21938

I can merge this if needed, not sure what's the status here. Fabrice, how can I help?
Flags: needinfo?(fabrice)
Update: there was a lint failure[1] in the patch, so I'm resubmitting with the error fixed.

I'm also closing the v2.0 pull in comment 4. I'll just attach the v2.0 PR with the other attachments.

[1] https://tbpl.mozilla.org/?rev=5a5a99c4869653a8ad89b831aa57a921b9ad8040&tree=Gaia-Try
Flags: needinfo?(fabrice)
Hey Fabrice - Same patch, now with the lint error fixed. Mind giving the official r+?
Attachment #8458759 - Attachment is obsolete: true
Attachment #8458868 - Flags: review?(fabrice)
Attachment #8458868 - Flags: review?(fabrice) → review+
Assignee: nobody → 6a68
Gaia-try looks good[1], merging. Thanks :fabrice and :mgoodwin!

Master: https://github.com/mozilla-b2g/gaia/commit/2abb279ae25e800f4b5e9b342b02e48405a777ad

v2.0: https://github.com/mozilla-b2g/gaia/commit/88f8e02da80eb6097f38a9ac9d8f46d67bf13e52


[1] https://tbpl.mozilla.org/?rev=4f88332dc07148262428e50d2ed15e1c6d74b250&tree=Gaia-Try
Status: NEW → RESOLVED
Closed: 10 years ago
status-b2g-v2.0: --- → fixed
status-b2g-v2.1: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S6 (18july)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: