Closed
Bug 1041237
Opened 10 years ago
Closed 10 years ago
The bitmask enums flags calculation for getBitToEnumValue is flawed
Categories
(DevTools Graveyard :: Canvas Debugger, defect)
DevTools Graveyard
Canvas Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 34
People
(Reporter: vporof, Assigned: vporof)
Details
Attachments
(1 file)
|
3.74 KB,
patch
|
jsantell
:
review+
|
Details | Diff | Splinter Review |
getBitToEnumValue("gl", ctx, ctx.TEXTURE_2D)
results in
"ONE | DEPTH_BUFFER_BIT | STENCIL_BUFFER_BIT | CW | CCW"
not
"TEXTURE_2D"
This happens most likely because a faulty regex.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8459244 [details] [diff] [review] v1 Review of attachment 8459244 [details] [diff] [review]: ----------------------------------------------------------------- Nice catch!
Attachment #8459244 -
Flags: review?(jsantell) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7a250901c59d
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7a250901c59d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
|
|
||
Updated•5 years ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•