1041618 - Enable history search on master

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Probably in search

Comment 3

[Kevin Grandon :kgrandon]

I have a patch in progress here: https://github.com/mozilla-b2g/gaia/pull/22024

Not sure if I will continue to work on this or not though as I'm not sure if we can turn this on yet due to the whole MozActivity thing. Let's discuss options today.

Comment 4

[Kevin Grandon :kgrandon]

Attachment: Pull request - enable places in master (no haida flag)

Hey - can you guys review this? I understand that we may want to block this until we have the icon sizes list fixed, in the meantime I think we should have this reviewed so we can be ready to go.

Also we may consider just wiping the places DB before launch, so maybe it's not a big deal to land early?

Comment 5

[Dale Harvey (:daleharvey)]

So https://bugzilla.mozilla.org/show_bug.cgi?id=968156 is the bug I wanna block this on, its in review but data storage format has changed several times so would definitely prefer it to land prior to this, the places db is never persisted, but the datastore is

Checking this out now though, can review and land straight after

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8460161 [details] [review]
Pull request - enable places in master (no haida flag)

Works well thanks, happy to land once the dependency does

Comment 7

[Kevin Grandon :kgrandon]

Comment on attachment 8460161 [details] [review]
Pull request - enable places in master (no haida flag)

Will go with Dale's review for now. Vivien - feel free to leave any comments.

Comment 8

[Kevin Grandon :kgrandon]

Enabled in master: https://github.com/mozilla-b2g/gaia/commit/b9240ad3dbb861c2e98150573ce6e4a64b300abb

Going to unblock 1041623 and 1042116, and block the parent user story with them.

Comment 9

[Miller Medeiros [:millermedeiros]]

hi Kevin, I think this patch introduced a small performance regression to the Calendar app (startup & moz-chrome-dom-loaded), do you think it's possible? see this comment for more info: https://bugzilla.mozilla.org/show_bug.cgi?id=1059349#c3 Thanks!

Comment 10

[Kevin Grandon :kgrandon]

(In reply to Miller Medeiros [:millermedeiros] from comment #9)
> hi Kevin, I think this patch introduced a small performance regression to
> the Calendar app (startup & moz-chrome-dom-loaded), do you think it's
> possible? see this comment for more info:
> https://bugzilla.mozilla.org/show_bug.cgi?id=1059349#c3 Thanks!

I've filed bug 1063789 to fix places performance.