1041623 - Properly dedupe places results according to spec

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect)

Comment 1

[Dale Harvey (:daleharvey)]

The spec for this is @ https://mozilla.app.box.com/s/lbw2wzw3p4jvxs24k4sg/1/2099951272/19056548695/1

Page 17/19

I am not confident the specification is going to be the final implementation, so calling this out as something that needs to be worked on and enabled soon to go through ux audit

Comment 2

[Dale Harvey (:daleharvey)]

dessign as I am not working on it this second

Comment 3

[Dale Harvey (:daleharvey)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/22308

Also revived and reused the places search test, for review purposes ignore any changes to app_chrome, they were causing this to fail but will be fixed seperately

Comment 4

[Kevin Grandon :kgrandon]

Comment on attachment 8464641 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/22308

Looks good, and thanks for taking a look at the test.

I left a comment on github and it looks like we may need to update a title assertion. Thanks!

Comment 5

[Dale Harvey (:daleharvey)]

https://github.com/mozilla-b2g/gaia/commit/f58bb4c40abbebd9ff9b32fb2a39bf3f44340991

Fixed up the assertions, issue was that a titlechange event may not have been sent down to places by the time we search, switched it to just make sure the app exists

Green try run except known intermitteng Gb @ https://tbpl.mozilla.org/?tree=Gaia-Try&rev=f3f49676690b