Closed
Bug 1041732
Opened 10 years ago
Closed 10 years ago
Make Details username should link to profile page
Categories
(Webmaker Graveyard :: webmaker.org, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: cade, Assigned: akshaytiwari.003, Mentored)
Details
(Whiteboard: [goodfirstbug] )
Attachments
(1 file, 1 obsolete file)
Username links in the make details page currently link to '/u/{username}' which is shorthand for a make search by that user's username. It should now link to the user's profile. There's two ways we can resolve this issue: 1. redirect /u/{username} to /user/{username} 2. update the make-details page to link "@username" to /user/{username} The upside of a redirect it it give a handy shortcut to /user/{username} - but also at the same time, /u/{username} is also handy for doing a search for a user's makes... My vote, based on the above, is to update the link in make details
Comment 1•10 years ago
|
||
Where should I fork it from? Could you give me the link? I want to try fixing the bug.
Flags: needinfo?(cade)
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to 14.jeevan from comment #1) > Where should I fork it from? Could you give me the link? I want to try > fixing the bug. fork from https://github.com/mozilla/webmaker.org
Flags: needinfo?(cade)
Reporter | ||
Updated•10 years ago
|
Mentor: cade
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → akshaytiwari.003
Assignee | ||
Comment 3•10 years ago
|
||
Hi cade, help me with the file location , will you?
Updated•10 years ago
|
Flags: needinfo?(cade)
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to akshaytiwari.003 from comment #3) > Hi cade, help me with the file location , will you? Look here: https://github.com/mozilla/webmaker.org/blob/5c29d2807666b13209400dd45bc512b644b781c4/views/details.html
Flags: needinfo?(cade)
Assignee | ||
Comment 5•10 years ago
|
||
Updated•10 years ago
|
Attachment #8479994 -
Flags: review?(cade)
Reporter | ||
Comment 6•10 years ago
|
||
Comment on attachment 8479994 [details] [review] Make Details username should link to profile page. I left a comment in the Github Pull Request for you to look at. Put the review back on me when you make the change.
Attachment #8479994 -
Flags: review?(cade) → review-
Comment 7•10 years ago
|
||
Since this was pending from 10 days, decided to submit the patch!
Attachment #8500312 -
Flags: review?(cade)
Comment 8•10 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/0717b8c816d5c94f1de6b8ab402e8885b5e3a7c5 Bug 1041732 - Make Details username should link to profile page
Assignee | ||
Comment 9•10 years ago
|
||
Status should be changed to resolved.
Reporter | ||
Comment 10•10 years ago
|
||
good call!
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Updated•10 years ago
|
Attachment #8500312 -
Attachment is obsolete: true
Attachment #8500312 -
Flags: review?(cade)
Reporter | ||
Updated•10 years ago
|
Attachment #8479994 -
Flags: review- → review+
You need to log in
before you can comment on or make changes to this bug.
Description
•