1041830 - Backout bug 1030206

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Walter Litwinczyk [:walter]]

Backing out bug 1030206 until it can be implemented with a better workaround.

Comment 1

[Walter Litwinczyk [:walter]]

Attachment: bug_1030206_backout_patch1

Made with hg diff -c 194567 --reverse

Comment 2

[Walter Litwinczyk [:walter]]

Attachment: bug_1030206_backout_patch2

Made with hg diff -c 194568 --reverse

Comment 3

[Walter Litwinczyk [:walter]]

Try: https://tbpl.mozilla.org/?tree=Try&rev=5b1c4bf698d8

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/88509c58e0d8
https://hg.mozilla.org/integration/mozilla-inbound/rev/d0413e0afd6a

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/88509c58e0d8
https://hg.mozilla.org/mozilla-central/rev/d0413e0afd6a

Comment 6

[Walter Litwinczyk [:walter]]

Comment on attachment 8459911 [details] [diff] [review]
bug_1030206_backout_patch1

Approval Request Comment (For Firefox v33)
[Feature/regressing bug #]:
  Bug 1041830

[User impact if declined]:
  Various online demos will be broken, including an upcoming demo from EPIC
  https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c24
  http://jonathan-olson.com/tesserace/tests/3d.html

[Describe test coverage new/current, TBPL]:
  Try: https://bugzilla.mozilla.org/show_bug.cgi?id=1041830#c3

[Risks and why]: 
  Requested by Sylvestre Ledru:
  https://bugzilla.mozilla.org/show_bug.cgi?id=1041301#c7

  and it's a breaking change because on windows ANGLE doesn't 
  fully support the needed extension, so it won't work at all:
  
  https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c37
[String/UUID change made/needed]:
  None

Comment 7

[Walter Litwinczyk [:walter]]

Comment on attachment 8459912 [details] [diff] [review]
bug_1030206_backout_patch2

See above request

Comment 8

[Sylvestre Ledru [:Sylvestre]]

(In reply to Walter Litwinczyk [:walter] from comment #6)
> 
> [Risks and why]: 
>   Requested by Sylvestre Ledru:
>   https://bugzilla.mozilla.org/show_bug.cgi?id=1041301#c7
> 
>   and it's a breaking change because on windows ANGLE doesn't 
>   fully support the needed extension, so it won't work at all:
>   
>   https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c37

Could you elaborate on this? What means "breaking change"? What is the impact to user if we revert in 33 too?
Thanks

Comment 9

[Walter Litwinczyk [:walter]]

Well it's 'breaking' in that the functionality of rendering to a floating point texture worked implicitly before and with the change it requires a preference to be enabled. This was unacceptable to some vendors. Additionally, even after enabling the pref it does not work on some platforms due to a limitation in our backend, whereas it worked without the change. Backing this out reverts Firefox to the old behavior that was being relied on in many applications.

A more elaborate explanation can be found here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1030206#c24

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8459912 [details] [diff] [review]
bug_1030206_backout_patch2

OK. If we come back to the 31 situation, I am happy with that!
Thanks

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/68538e095002

Pushed as one folded patch because the commit messages were basically the same anyway.