1042706 - The filters menu/panel obscures the main page content

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Ed Morley [:emorley]]

STR:
1) Go to https://treeherder.mozilla.org/ui/#/jobs
2) Click the "filters" menu so the panel opens up
3) Try to view the job results for the push at the top of the page

Expected:
After opening the panel, it's possible to scroll up higher, to see the now covered up content. Or ideally, opening the panel scrolls the content down so the topmost visible items are still visible.

Actual:
Panel covers up the topmost push/job results and you have to close the filters panel to see them.

Comment 1

[Cameron Dawson [:camd]]

Maybe we could just make these panels be modal dialogs that pop up, so they're more obviously something you change, then dismiss, without expecting to interact with jobs at the same time?

the sheriff menu should probably be a separate view, rather than a drop-down panel.
the repos list could probably just be a normal menu.  perhaps keep the check boxes to watch more than one.

Comment 2

[Ed Morley [:emorley]]

(In reply to Cameron Dawson [:camd] from comment #1)
> Maybe we could just make these panels be modal dialogs that pop up, so
> they're more obviously something you change, then dismiss, without expecting
> to interact with jobs at the same time?

Yeah I think that makes sense (so long as quickfilter does enough that using the main filters menu is rare and/or we partially combine the two as mentioned in another bug).

> the sheriff menu should probably be a separate view, rather than a drop-down
> panel.

Yeah sgtm.

> the repos list could probably just be a normal menu.  perhaps keep the check
> boxes to watch more than one.

Yeah a menu works well in TBPL; but open to ideas (I'm not saying different from TBPL is bad :-))

Comment 3

[:Paolo Amadini]

I filed bug 1045618 for the repos panel, but it might be reduced in scope to only replace the checkboxes with plus icons, if you're going to move all the panels to be modal dialogs at once in this bug. A requirement of those dialogs, anyways, would be to use all the space available to avoid unnecessary scrolling.

Comment 4

[William Lachance (:wlach)]

I'm 75% of the way to fixing this (wanted to do it for bug 1062535)

Comment 5

[William Lachance (:wlach)]

This has been fixed for a long time.