1042761 - onResponse is not a function at dbg-client.jsm:1670

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

STR:

1. Open the debugger in http://todomvc.com/architecture-examples/backbone/
2. Open the events pane and choose to break on click events.
3. Click in the input box and then clear the break-on-click checkbox.
4. The Browser Console contains the error: onResponse is not a function at dbg-client.jsm:1670

Patch forthcoming.

Comment 1

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Ensure that the debugger client doesn't try to call a callback, when one is not provided

Fortunately this bug doesn't break anything for me, because the error is thrown in a setTimeout call, so the event loop is empty. I've looked around in the debugger client and there are a number of other cases where we assume the caller will supply a callback that I also fixed.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Rather than repeating `() => {}` everywhere, can we just define `const noop = () => {};` and use that?

Comment 3

[Panos Astithas (he/him) [:past] (please ni?)]

https://tbpl.mozilla.org/?tree=Try&rev=809746911f30

Comment 4

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Ensure that the debugger client doesn't try to call a callback, when one is not provided v2

Good idea, but used let instead of const, because there was a redeclaration error that I didn't want to figth with.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

https://hg.mozilla.org/integration/fx-team/rev/01d60712d7a4

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/01d60712d7a4

Comment 7

[Hossain Al Ikram [:ikram] (QA Contact)]

Panos Astithas, could you please add another test page? The one from comment 0 seems to not be available. Thank you

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

It seems to be moved here:
http://todomvc.com/examples/backbone/