1042825 - Pressing undo twice after loading a file clears out the content

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Brian Grinstead [:bgrins]]

STR:
1) Open a file in the project editor (say, styles.css here: chrome://browser/content/devtools/projecteditor-loader.xul)
2) Undo twice

Expected
Nothing happens when undoing (the file just loaded and you haven't made any changes)

Actual
The contents of the editor is cleared out

There is a clearHistory provided by the Editor object, so it may just be as simple as calling that after calling setText in editor.load

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: undo-clear.patch

This fixes the issue

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8469254 [details] [diff] [review]
undo-clear.patch

Review of attachment 8469254 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to work well!  Thanks!

Comment 3

[Brian Grinstead [:bgrins]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=73788c21213b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/2ead24c96a8e

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2ead24c96a8e

Comment 6

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed using latest Aurora 34.0a2 build (20141008004004) under Win 7 64-bit, Ubuntu 13.04 64-bit and Mac OSX 10.9.5. Undo is active only after modifying file's content.