1042844 - [Loop][Visual] Implement call screen visuals

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Borja Salguero [:borjasalguero]]

Implement final design of call screen.

Comment 1

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

Comment 2

[Maria Angeles Oteo (:oteo)]

Setting the corresponding dependencies as this bug blocks all the User Stories included in these meta bugs:
Bug 1002756 - (loop_start_call) [Meta] for Starting Loop Calls from Loop Mobile Client
Bug 1002768 - (loop_receive_call) [Meta] for Receiving Calls in Loop in Loop Mobile Client
Bug 1002763 - (loop_join_calls) [Meta] for Opening URL Callbacks from Loop Mobile Client
Bug 1002774 - (loop_incall_features) [Meta] for In-Call Features in Loop Mobile Client
Bug 1002782 - (loop_post_calls) [Meta] for Post-Call Features in Loop Mobile Client

Comment 3

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8461022 [details] [review]
Pull Request

The CSS part looks good ;)

Comment 4

[José Antonio Olivera Ortega [:jaoo]]

Comment on attachment 8461022 [details] [review]
Pull Request

The JS part looks good to me as well. r=me

I left a few comments on the PR, please address them before landing this. Another thing is that the version is not correctly bumped up. You should have a couple of commits in the PR, the one with the logic being added and the one with the new version. Please ping me in case you have any doubt about the bumping up version mechanism works.

Comment 5

[Victoria Gerchinhoren [:vicky]]

Comment on attachment 8461022 [details] [review]
Pull Request

As reviewed offline, basic implementation is ok, but a follow up on details is needed. 
Great job!

Comment 6

[Borja Salguero [:borjasalguero]]

Last bits will be added in the final 'polish' follow up bug. R+ so merging!