Closed
Bug 1043045
Opened 10 years ago
Closed 10 years ago
Port |Bug 1036894 - Move in-tree library linkage information to moz.build| to im
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: clokep, Assigned: florian)
References
Details
Attachments
(3 files, 5 obsolete files)
|
2.18 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
|
4.95 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
|
1.13 KB,
patch
|
clokep
:
review+
|
Details | Diff | Splinter Review |
There's a few build bustages, let's handle them here.
|
Reporter | |
Comment 1•10 years ago
|
||
|
|
Reporter | |
Comment 2•10 years ago
|
||
See bug 1043019, but we have to port the purple/ stuff somewhere too so we can morph this bug.
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8461219 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 4•10 years ago
|
||
These 2 patches produced a working Mac Debug build. We need to clean them up, see what's Mac-only vs what should apply on all platforms, and make the same changes to mintrayr.
Attachment #8461221 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8461273 -
Attachment is obsolete: true
Attachment #8461448 -
Flags: review?(clokep)
|
|
Reporter | |
Comment 6•10 years ago
|
||
Comment on attachment 8461448 [details] [diff] [review] purple/ changes v3 Review of attachment 8461448 [details] [diff] [review]: ----------------------------------------------------------------- Looks good overall. I don't like the QQ change, we should probably just disable building it (in a separate patch). People reported recently that it's not working anyway.
Attachment #8461448 -
Flags: review?(clokep) → review-
|
|
Assignee | |
Comment 7•10 years ago
|
||
Assignee: nobody → florian
Attachment #8461272 -
Attachment is obsolete: true
Attachment #8461475 -
Flags: review?(clokep)
|
|
Reporter | |
Comment 8•10 years ago
|
||
Comment on attachment 8461475 [details] [diff] [review] im/ changes v3 Review of attachment 8461475 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, testing this on Linux right now.
Attachment #8461475 -
Flags: review?(clokep) → review+
|
|
Assignee | |
Comment 9•10 years ago
|
||
- Removed the qq change that was here by accident. - Two additional EXTRA_LIBS -> OS_LIBS that are required for building on Windows.
Attachment #8461448 -
Attachment is obsolete: true
Attachment #8461563 -
Flags: review?(clokep)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8461563 -
Flags: review?(clokep) → review+
|
|
Reporter | |
Comment 10•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1b51a4f02a62 http://hg.mozilla.org/users/florian_queze.net/purple/rev/e69eedb84ede Going to restart nightly builds now. Thanks Florian!
|
|
Assignee | |
Comment 11•10 years ago
|
||
Attachment #8461753 -
Flags: review?(clokep)
|
|
Reporter | |
Updated•10 years ago
|
Attachment #8461753 -
Flags: review?(clokep) → review+
|
|
Reporter | |
Comment 12•10 years ago
|
||
http://hg.mozilla.org/users/florian_queze.net/purple/rev/e62dedb0bc17
You need to log in
before you can comment on or make changes to this bug.
Description
•