104311 - Imagelib uses too much XPCOM

Status: VERIFIED FIXED

(Core :: Graphics: ImageLib, defect, P2)

Description

[Stuart Parmenter]

Imagelib uses too much XPCOM/virtual functions internally.  We can remove most 
of the internal functions and leave the XPCOM stuff only on the outside.

Comment 1

[Stuart Parmenter]

Attachment: Patch to remove the internal virtual function crap

Comment 2

[Stuart Parmenter]

This patch removes the virtual function call use between the imgRequest and 
imgRequestProxy classes.

I create a imgILoad interface that is only used by decoders to set/get the 
image that they are responsible for creating.

With this patch, I make imgRequest no longer inherit from imgIRequest. I should 
rename imgRequest.[cpp/h] to imgLoad.[cpp/h], but I'll do that in another step 
as I would prefer to not lose version history. I will see if leaf can help out 
with this.  I could probably also rename imgRequestProxy to imgRequest..  i'll 
rename files later.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 53202 [details] [diff] [review]
Patch to remove the internal virtual function crap

r=bryner, with the corrections we talked about on irc

Comment 4

[(not reading, please use [e-mail] instead)]

Comment on attachment 53202 [details] [diff] [review]
Patch to remove the internal virtual function crap

sr=sspitzer

stuart tells me he tested a whole bunch, including mailnews.

Comment 5

[Stuart Parmenter]

fix checked in.

Comment 6

[Stuart Parmenter]

Attachment: Remove the unused 'cx' param

Comment 7

[David Hyatt]

sr=hyatt on 2nd patch

Comment 8

[Brian Ryner (not reading)]

Comment on attachment 53232 [details] [diff] [review]
Remove the unused 'cx' param

r=bryner

Comment 9

[jag (Peter Annema)]

Comment on attachment 53232 [details] [diff] [review]
Remove the unused 'cx' param

r=jag

Comment 10

[Stuart Parmenter]

2nd patch checked in

Comment 11

[Terri Preston]

Verified fix checked into lxr.mozilla.org