1043518 - Typing a long message or contact-name in SMS app will push the "send" / "add contact" buttons offscreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Open SMS app
 2. Tap the "new message" icon near upper-right
 3. Type "aaaaaaaaaaaaaaaaaaaaa..." [etc] until you overflow the available horizontal space

ACTUAL RESULTS: The "+" / "Send" button at the right of the field is pushed offscreen.

This is likely due to bug 984711 / bug 1037177 establishing a minimum size for flex items, based (in part) on the item's min-content size.

We can override it by using "min-width:0" in the right place (on the flex item that contains these text fields).

(Alternately, setting a "max-width" or "width" would also work, as would putting "overflow-x: scroll", per http://dev.w3.org/csswg/css-flexbox/#min-size-auto -- but those changes would all be more likely to affect the layout in other ways.)

Discovered when trying to repro bug 1042887 in up-to-date gaia with latest b2g desktop build from http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: wip

This patch fixes the issue (in both the contact box and the message-body box), though it's a bit heavy-handed (targeting all elements).

Really this should just be on 2 specific CSS rules, probably. (I just don't know which exact 2 yet.)

Comment 2

[Julien Wajsberg [:julienw]]

We can probably handle it along with bug 1042887. The SMS team can take it from here if you want!

Comment 3

[Julien Wajsberg [:julienw]]

[Blocking Requested - why for this release]:

Comment 4

[Daniel Holbert [:dholbert]]

Sounds good to me! Let me know if you need any more from me here.

Comment 5

[Daniel Holbert [:dholbert]]

Attachment: pull request

Actually, with the method in bug 1042887 comment 13, I was able to quickly track down the flex items that need "min-width:0" using firefox's devtools, so I'll go ahead and take this.

Pull request: https://github.com/mozilla-b2g/gaia/pull/22127

Comment 6

[Oleg Zasypkin [:azasypkin]]

Comment on attachment 8461917 [details] [review]
pull request

r=me with a one more "min-width: 0;" for the message body (commented on GitHub).

Thanks!

Comment 7

[Daniel Holbert [:dholbert]]

Updated the pull request with that change. Thanks!

Comment 8

[Julien Wajsberg [:julienw]]

Since it's r+, feel free to merge yourself Daniel! Or set checkin-needed if you don't have the rights, when you're ready :)

Comment 9

[Daniel Holbert [:dholbert]]

Thanks! I don't believe I have merge rights for mozilla's github projects (or if I do, I wouldn't trust myself to use them properly, w/ my current git/github comfortability). :)

Hence, using checkin-needed.

Comment 10

[Oleg Zasypkin [:azasypkin]]

Master: https://github.com/mozilla-b2g/gaia/commit/a67cd9ee28d3b0456e323bea77a6dfbc69dc98b3