1043605 - error: 'mutationCount' was not declared in this scope

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[Michael Schwartz [:m4]]

From change https://bugzilla.mozilla.org/show_bug.cgi?id=1038601, HashTable::mutationCount is declared conditionally based on the JS_DEBUG pound define [1] but used conditionally by DEBUG pound define [2].  In some builds, DEBUG is defined but JS_DEBUG is not.

Perhaps mutationCount should be pulled out and wrapped by DEBUG instead.

[1] https://github.com/mozilla/gecko-dev/blob/256a1f168b345758d1ce83f6575d6543f8bec738/js/public/HashTable.h#L1005
[2] https://github.com/mozilla/gecko-dev/blob/256a1f168b345758d1ce83f6575d6543f8bec738/js/public/HashTable.h#L1089

Comment 1

[Nicholas Nethercote [inactive]]

Oh, since I've posted a fix patch as a follow-up in bug 1038601, how about we just continue things there?

Comment 2

[Michael Vines [:m1] [:evilmachines]]

I'm reopening this bug because a patch has already landed in bug 1038601.  It's confusing to post follow-up patches to bugs that are already RESOLVED.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Fix up DEBUG/JS_DEBUG confusion in HashTable.h

Moving the patch from bug 1038601 to here.

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 8470641 [details] [diff] [review]
Fix up DEBUG/JS_DEBUG confusion in HashTable.h

Review of attachment 8470641 [details] [diff] [review]:
-----------------------------------------------------------------

Carrying over r+ from bug bug 1038601.

Comment 5

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e4f87d728f9d

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Ta!

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e4f87d728f9d