Closed
Bug 1043951
Opened 10 years ago
Closed 6 years ago
Python runner-service shouldn't do its own log formatting/handling
Categories
(Testing Graveyard :: JSMarionette, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
People
(Reporter: ahal, Unassigned)
References
Details
(Whiteboard: [runner][device][emulator])
Instead it should use mozlog.structured formatters/handlers. Rather than implement this itself, I think this is something that should get built right into corredor. This bug tracks the change to use the new corredor functionality.
Reporter | ||
Comment 1•10 years ago
|
||
Hey Malini, Fyi, I had a patch lying around for bug 1043945 that I just landed: https://github.com/ahal/corredor/commit/bd70ff3cfde43823e59c0b9ebc1fe8a8b7d18620 It should make it easier for you to use the structured logging module with the test results you are receiving over the socket. What I had in mind was: 1) Add structured logging commandline args to the ArgumentParser here [1] 2) Create structured logger object with [2] and pass it into listener.py 3) Instead of creating a Subscriber here [3], it should be possible to create a StructuredLoggerBridge and all output logging would get handled automatically (no need for those "on_test_start" etc. handlers). [1] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/runner-service/runner_service/runintegration.py#L59 [2] http://mxr.mozilla.org/mozilla-central/source/testing/mozbase/mozlog/mozlog/structured/commandline.py#109 [3] https://github.com/mozilla-b2g/gaia/blob/master/tests/python/runner-service/runner_service/listener.py#L31
Updated•10 years ago
|
Summary: Python runner-service shouldn't do it's own log formatting/handling → Python runner-service shouldn't do its own log formatting/handling
Updated•10 years ago
|
Whiteboard: [runner][device][emulator]
Comment 2•6 years ago
|
||
Bulk closed as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1422750
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
Updated•6 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•