Closed Bug 1044277 Opened 10 years ago Closed 10 years ago

[RTL][Overlay] Geolocation Overlay buttons are a bit crowded

Categories

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.0 affected, b2g-v2.1 verified, b2g-v2.2 verified)

VERIFIED FIXED
Tracking Status
b2g-v2.0 --- affected
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: nhirata, Unassigned)

References

Details

(Whiteboard: [2.0-319MB-bug-bash])

Attachments

(2 files, 1 obsolete file)

Attached image 2014-07-25-15-30-55.png
1. set device to arabic
2. go to browser
3. go to maps.google.com

Expected: buttons are spaced out
Actual: buttons are crowded

Gaia      3a06aa58245eaf848242d6d1497c1af536fffabd
Gecko     https://hg.mozilla.org/mozilla-central/rev/6c0971104909
BuildID   20140725040205
Version   34.0a1
ro.build.version.incremental=110
ro.build.date=Fri Jun 27 15:57:58 CST 2014
B1TC00011230
Pavel, is this something you can take on or would you need some UX guidance first? Let me know and thanks!
Flags: needinfo?(pivanov)
Attached file patch for Gaia/master (obsolete) —
Attachment #8470127 - Flags: review?(21)
Flags: needinfo?(pivanov)
Attachment #8470127 - Attachment is obsolete: true
Attached file patch for Gaia/master
(wrong attachment)
r=vingtetun
Attachment #8477389 - Flags: review+
Thanks :)

Landed to master:
https://github.com/mozilla-b2g/gaia/commit/380d6a3f06438ee85e847585df662fd0e144777e
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Hello Pavel, 

I am doing verifications on this bug, and from the image that is prompted on my screen and the screen shot provided, I do not really see any changes. As I do not speak or read the language I could be wrong, any information would help me to finish this verification, Thanks.
Flags: needinfo?(pivanov)
The problem here was that the buttons adjoin themselves. Hope this helps
Flags: needinfo?(pivanov)
This issue is verified fixed on Flame 2.1 and 2.2.

Result: The buttons are aligned properly without being too close to each other.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141202001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0
  
Device: Flame 2.2 (319mb, KK, Full Flash)
BuildID: 20141202040207
Gaia: 725685831f5336cf007e36d9a812aad689604695
Gecko: 2c9781c3e9b5
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Mass Edit: adding the [rtl-meta]
Whiteboard: [2.0-319MB-bug-bash] → [rtl-meta]
Whiteboard: [rtl-meta] → [rtl-meta][2.0-319MB-bug-bash]
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][rtl-impact]
Whiteboard: [rtl-meta][2.0-319MB-bug-bash] → [2.0-319MB-bug-bash]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: