104447 - Vertical bars after spaces in mime encoded header with mixed characters

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect, P2)

Description

[Dimitrios]

As you can see on the attached screenshot, bold vertical bars are inserted when
there are spaces between latin and non latin characters. In the highlighted
message, subject contains some combinations of the "a" and "b" characters with
various ones from the greek alphabet. It is obvious that not all combinations
result in vertical bars. And there's no problem in message pane.

Build 2001101203 (note that I see it for months).

Comment 1

[Dimitrios]

Attachment: screenshot

Comment 2

[Dimitrios]

This is the message source for the highlighted header in the previous screenshot:

X-Accept-Language: el, en
MIME-Version: 1.0
To: [e-mail]
Subject: a =?ISO-8859-7?Q?=E1?= a =?ISO-8859-7?Q?=E2?= a 
	=?ISO-8859-7?Q?=E3?= a =?ISO-8859-7?Q?=E4?= a 
	=?ISO-8859-7?Q?=E5?= a =?ISO-8859-7?Q?=E6?= a 
	=?ISO-8859-7?Q?=E7?= a =?ISO-8859-7?Q?=E8?=     b 
	=?ISO-8859-7?Q?=E1?= b =?ISO-8859-7?Q?=E2?= b 
	=?ISO-8859-7?Q?=E3?= b =?ISO-8859-7?Q?=E4?= b 
	=?ISO-8859-7?Q?=E5?= b =?ISO-8859-7?Q?=E6?= b 
	=?ISO-8859-7?Q?=E7?= b =?ISO-8859-7?Q?=E8?= 
Content-Type: text/plain; charset=ISO-8859-7; format=flowed
Content-Transfer-Encoding: 7bit
Status:   

Comment 3

[nhottanscp]

Confirm based on the screen shot?

Comment 4

[Dimitrios]

Attachment: Messages of the screenshot., Unzip this into Local Folders (but contains non latin characters)

Comment 5

[Dimitrios]

Attachment: Messages of the screenshot (better attempt)

Comment 6

[ji]

On my Japanese XP with 10/12 0.9.4 build, Japanese period is displayed instead.

Comment 7

[nhottanscp]

Tabs used for line folding are not removed and shown in thread pane. I think
jgmyers fixed this before, cc to him.

Comment 8

[John G. Myers]

*** This bug has been marked as a duplicate of 64948 ***

Comment 9

[Takayuki Tei]

Although this is also causing bug 64948, the root cause of this symptom
is different from bug 64948.  Folding long header is broken, thus
should be tracked as a different bug.  Re-opening.

Comment 10

[Takayuki Tei]

Reassign to myself.  Change TM to 0.9.6.

Comment 11

[Takayuki Tei]

Attachment: proposed fix

Comment 12

[nhottanscp]

Taka, could you put a decsription about your change?
Cc to ducarroz.

Comment 13

[John G. Myers]

Bug 73403 tracks the error in the header encoder/folder.

Comment 14

[Takayuki Tei]

The new code checks if there is a LWSP character already at where we are
about to fold.  If there is, inserts CR/LF before this LWSP instead of
inserting extra TAB regardless which causes this symptom.  This way,
new code becomes RFC-822 compliant as opposed to the previous code.

As for MIME encoded word, it always uses SPACE as LWSP.

Comment 15

[Takayuki Tei]

Shall we close this bug as dup of bug 73403 ?

Comment 16

[Takayuki Tei]

My conclusion is to deal with bug 73403 as a different problem from this bug.
Keep this bug opened.

Naoki,
Who can be s/sr for this propsed fix?

Comment 17

[ji]

Added nsbeta1 keyword.

Comment 18

[Jonadab the Unsightly One (Nathan Eady)]

0.9.6 is out the door.

Comment 19

[Takayuki Tei]

change TM to 0.9.7.

Comment 20

[Takayuki Tei]

change TM to 0.9.8.

Comment 21

[Takayuki Tei]

Set TM to 0.9.9.

Comment 22

[Takayuki Tei]

As a result of new MIME encoder, which is originally written to fix #73403,
this bug should be also fixed by applying the proposed patch (id=67007) 
submitted on 1/29/2002.  Please down load and apply the patch and see how
it fixes this problem as well.

Comment 23

[Dimitrios]

I understand that, due to the "international" nature of this bug, I am pretty
responsible for testing the proposed fix. Alas, I don't have a building
environment available. Is it possible for someone else to make a build with this
pach? Thanks in advance. 

Comment 24

[Denis Antrushin]

Just close it as dup of bug 73403 :-))

Comment 25

[Dimitrios]

Patch still makes Mail client unusable (build 2002020103) or even crashing
(build 2002013103). Tested on Win98 and Win2K.

Comment 26

[Takayuki Tei]

Don't think the files I gave you as patch.  It's crashing due to unresolved
symbols at runtime, not any other reason which might be introduced by the patch.

You have to download the patch for bug 73403, apply to your source tree,
and build by yourself.  Or, wait until the patch gets checked into CVS.

Comment 27

[Takayuki Tei]

add dependency

Comment 28

[Takayuki Tei]

Mark as fixed.  See bug 73403 for detail.

Comment 29

[Dimitrios]

Yes!! All those ugly characters that were making my Mozilla Mail looking like a
home-made application have been vanished. Congratulations. Marking as verified,
Win2K, 2002022003 (it remains to see if it works on Win98 at home but I am too
glad to wait :-)).