Closed
Bug 1044488
Opened 10 years ago
Closed 10 years ago
Toolbox Options has NULL title
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 34
People
(Reporter: jjdsampson, Assigned: past, Mentored)
References
Details
Attachments
(2 files)
30.07 KB,
image/gif
|
Details | |
3.06 KB,
patch
|
jwalker
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 6.4; WOW64; Trident/7.0; .NET4.0E; .NET4.0C; .NET CLR 3.5.30729; .NET CLR 2.0.50727; .NET CLR 3.0.30729; InfoPath.3; rv:11.0) like Gecko Steps to reproduce: 1. Right click anywhere and Inspect Element. 2. With Developer Tools opened, click into Toolbox Options. Actual results: Title of Developer Tools window changed from "Inspector - <url>" to "(null) - <url>". Expected results: Title of Developer Tools window [should] change from "Inspector - <url>" to "Options - <url>".
Severity: normal → minor
Status: UNCONFIRMED → NEW
Component: Untriaged → Developer Tools
Ever confirmed: true
OS: Windows NT → All
Hardware: x86_64 → All
Assignee | ||
Comment 1•10 years ago
|
||
I decided to not special-case the options panel any further, but add an iconOnly property to the tool definitions that can be used to omit the tool's label from the tab.
Attachment #8463394 -
Flags: review?(jwalker)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Updated•10 years ago
|
Attachment #8463394 -
Flags: review?(jwalker) → review+
Assignee | ||
Comment 2•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/227521be1def
Comment 3•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/227521be1def
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
Mentor: ejpbruel
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•