1045029 - Update test_gallery_view to use 'portrait' instead of 'portrait-primary'

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Florin Strugariu [:Bebe]]

Our gallery tests are failing because the device are positioned upside down (With the USB plug up) because of space reasons.

In the gallery test we check the screen orientation and we expect it to be "portrait-primary" and currently it's "portrait-secondary"

Because of that we see failing tests in our runs.

Update the test to check that the orientation is: "portrait"

Comment 1

[Florin Strugariu [:Bebe]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22214

Can you guys take a look over this and see if it's OK

Comment 2

[Zac C (:zac)]

Dylan plans to move them all up the other way but I'll try and get a handle on the timeframe and get back to you. It'd be better to keep this test the way it is.

Comment 3

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8463358 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22214

I don't have a problem if this is our only option, but I would prefer to either keep the devices the right way up, or to force the initial orientation in the test setUp. Making the test itself more vague is the least desirable solution.

Comment 4

[Dylan Chun Wong [:dwong]]

The cables have been ordered, and once they get here we will flip all the devices right side up.

Comment 5

[Zac C (:zac)]

Let's not do this solution.