Closed
Bug 104518
Opened 23 years ago
Closed 23 years ago
CharDetNativeTest
Categories
(Core :: Internationalization, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: jonsmirl, Assigned: shanjian)
Details
(Keywords: intl)
Attachments
(1 file)
476 bytes,
patch
|
nhottanscp
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
/intl/charset/src/windows/* Is this module still used by Mozilla? I played around for a while and couldn't figure out how to get it loaded into memory. I also search around for it's CIDs and couldn't find anyone loading them. This module is exporting: NSCanUnload NSGetFactory NSRegisterSelf NSUnregisterSelf instead of the standard NSGetModule The module is building and installing as part of the app. But it is the only module in Mozilla that is not exporting NSGetModule. It should probably be updated to use the GenericModule support.
Also, chardet/classic and chardet/windows and both being compiled and built into Mozilla.
Comment 3•23 years ago
|
||
cc nhotta in case he knows what's going on with these (or knows someone who does)
Comment 4•23 years ago
|
||
It is not used. The detector is using OS provided detector.
Assignee | ||
Comment 5•23 years ago
|
||
I think that module was written by naoki as a wrapper of a MS charset detection dll. It has never been used mozilla. We might want to leave the code there, but there is really no need to build it or update it. I don't think we will ever use it in future.
Status: NEW → ASSIGNED
Assignee | ||
Comment 6•23 years ago
|
||
Assignee | ||
Comment 7•23 years ago
|
||
frank, naoki, I guess classic can be removed too. Is that right?
Comment 8•23 years ago
|
||
Comment on attachment 53611 [details] [diff] [review] patch sr=alecf assuming everyone is in agreement.
Attachment #53611 -
Flags: superreview+
Comment 9•23 years ago
|
||
Comment on attachment 53611 [details] [diff] [review] patch r=nhotta
Attachment #53611 -
Flags: review+
Assignee | ||
Comment 10•23 years ago
|
||
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla0.9.6
Comment 11•23 years ago
|
||
Switching qa contact to ftang for now. Frank, can this bug be verified within development or can you provide QA with a test case? Thanks.
Keywords: intl
QA Contact: andreasb → ftang
You need to log in
before you can comment on or make changes to this bug.
Description
•