Closed Bug 1045223 Opened 10 years ago Closed 10 years ago

Creating events per drag doesn't take default status values into account

Categories

(Calendar :: Calendar Frontend, defect)

Lightning 3.3
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: bv1578)

References

Details

Attachments

(1 file)

Bug 998281 gave enhanced preferences for a default event status. While creating a new event per drag in day or week view, these prefs aren't taken into account, the event has no default status.
I guess you have to add one more call for setDefaultItemValues(item) somewhere around http://mxr.mozilla.org/comm-central/source/calendar/base/content/calendar-views.js#35 (that works for me extension-wise).

Seen with Lightning 3.3 and 3.6a1.
Attached patch patch - v1 β€” β€” Splinter Review
If we use setDefaultItemValues() for the default status we can also use it to set the calendar, alarms and start/end date-times (so we avoid to set these elements twice).

Alternatively we can simply add this line inside the function createNewEvent:
item.setProperty("TRANSP", cal.getEventDefaultTransparency(aForceAllday));
Assignee: nobody → bv1578
Status: NEW → ASSIGNED
Attachment #8464304 - Flags: review?(philipp)
Attachment #8464304 - Flags: review?(philipp) → review+
Keywords: checkin-needed
OS: Windows 7 → All
Hardware: x86 → All
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/19f995a8be86>
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: