1045760 - Enhance tiles more specifically than eTLD+1/baseDomain (e.g., no enhance bugzilla.mozilla.org for mozilla.org)

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect)

Description

[Ed Lee :Mardak]

jaws points out that the current eTLD+1/baseDomain enhancement causes bugzilla.mozilla.org to be enhanced by mozilla.org's enhanced tile.

Fyi, bug 990322 is to only show one thumbnail from a given eTLD+1, so if the user would have both bugzilla.mozilla.org and mozilla.org, only one of them would be shown, and we would probably want to enhance that one tile.

An alternative I mentioned in bug 990322 comment 4 is that maybe we should just take the whole domain.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

If we did this, we need to treat 'www.example.com' as the same as 'example.com', and potentially any other generic subdomains.

Comment 2

[Ed Lee :Mardak]

(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #1)
> If we did this, we need to treat 'www.example.com' as the same as
> 'example.com', and potentially any other generic subdomains.
Not sure what's a good way to handle this and if that blocks fixing this bug or not.

Doing a quick scan through my top tiles, I see prefixes including www. wwws. online. m. web. for english sites.

Comment 3

[Ed Lee :Mardak]

Also, dao has a patch in bug 990322 to remove repeat tiles from the same eTLD+1, but we probably want to use the same logic here and there.

Comment 4

[Ed Lee :Mardak]

We won't do something smarter than eTLD+1 initially especially given bug 990322 probably landing soon where there wouldn't be multiple tiles from the same eTLD+2 but same eTLD+1.

Comment 5

[Kevin Brosnan [Ex-Mozilla]]

This has more or less broken the new tab page for me. I went from having 9 useful tiles to 1 often used tile, 5 infrequently visited tiles and 9 blank tiles.

Comment 6

[Ed Lee :Mardak]

(In reply to Kevin Brosnan [:kbrosnan] from comment #5)
> I went from having 9 useful tiles to 1 often used tile, 5 infrequently visited
This bug 1045760 is part of making that smarter instead of only going by eTLD+1. Curious, are the tiles getting merged all mozilla.org? You can drag bookmarks into the new tab tiles to pin a site (where pinned sites don't get duped).

Comment 7

[Thomas Stache]

(In reply to Ed Lee :Mardak from comment #6)
> Curious, are the tiles getting merged all mozilla.org? You can drag bookmarks  
> into the new tab tiles to pin a site (where pinned sites don't get duped).

Yes, multiple manually pinned tiles are getting the mozilla.org "banner" image and identical tile title. You have to hover to reveal the actual link.

Comment 8

[Ed Lee :Mardak]

Attachment: v1

Comment 9

[Ed Lee :Mardak]

Attachment: v1

Comment 10

[Ed Lee :Mardak]

With my own profile, the patch here shows these additional sites:

(tbpl.mozilla.org current top eTLD+1 mozilla.org)
bugzilla.mozilla.org
air.mozilla.org
hg.mozilla.org
addons.mozilla.org
trychooser.pub.build.mozilla.org
intranet.mozilla.org

(cloud.feedly.com current top eTLD+1 feedly.com)
feedly.com

(mail.google.com current top eTLD+1 google.com)
docs.google.com
maps.google.com
news.google.com
drive.google.com
www.google.com (/flights)
plus.google.com

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 8481076 [details] [diff] [review]
v1

>+      let eTLD2 = Services.eTLD.getBaseDomain(uri, 1);

eTLD+2 doesn't make much sense to me. It seems arbitrary...? Why not use the full domain at this point?

>+      // Strip off common subdomains of the same site (e.g., www, load balance)
>+      return eTLD2.replace(/^(m(obile)?|secure|www*s?)\d*\./, "");

This is kind of annoying, this list will get very long if it should cover a wide range of non-distinctive subdomains (let alone for different locales). And then there will be false positives, e.g. there might be good reasons why a user would choose between secure.foo.bar and foo.bar depending on the situation.

By the way, what's wws / wwws? I don't recall having ever seen this.

Comment 12

[Ed Lee :Mardak]

Attachment: v2

(In reply to Dão Gottwald [:dao] from comment #11)
> >+      let eTLD2 = Services.eTLD.getBaseDomain(uri, 1);
> eTLD+2 doesn't make much sense to me. It seems arbitrary...? Why not use the
> full domain at this point?
That's exactly what I said in bug 990322 comment 4! ;) Switched to just asciiHost.

At least from my own top 100 links, the only difference between eTLD+2 vs asciiHost (assuming the same www-type cleanup) is build.mozilla.org vs trychooser.pub.build.mozilla.org.

> >+      // Strip off common subdomains of the same site (e.g., www, load balance)
> >+      return eTLD2.replace(/^(m(obile)?|secure|www*s?)\d*\./, "");
> This is kind of annoying, this list will get very long if it should cover a
> wide range of non-distinctive subdomains (let alone for different locales).
Nod. I was analyzing all the hosts in my moz_hosts and there were other ones that came up such as i\d*. s\d*. although the latter would have incorrectly trimmed off s3.amazonaws.com.

> And then there will be false positives, e.g. there might be good reasons why
> a user would choose between secure.foo.bar and foo.bar depending on the
> situation.
> By the way, what's wws / wwws? I don't recall having ever seen this.
The secure and www*s are related where some sites use "wwws" to imply a secure subdomain. Actually, I only see it for mint.com. Removed secure/wwws.

Comment 13

[Dão Gottwald [:dao]]

Comment on attachment 8481450 [details] [diff] [review]
v2

>+    // Strip off common subdomains of the same site (e.g., www, load balancer)
>+    return uri.asciiHost.replace(/^(m(obile)?|www*)\d*\./, "");

I'd prefer m|mobile over m(obile)?.

I don't think m\d, mobile\d, ww or wwww are common enough to be included here. Can you remove them too?

Comment 14

[Ed Lee :Mardak]

Attachment: v3

Comment 15

[Ed Lee :Mardak]

Comment on attachment 8481542 [details] [diff] [review]
v3

Approval Request Comment
[Feature/regressing bug #]: bug 990322 / bug 1036299
[User impact if declined]: Only one mozilla.org tile will be shown/enhanced limiting our ability to multiple mozilla directory tiles (e.g., mozilla, android, customize, mdn, etc.). Some *.mozilla.org users have reported reduced usefulness of the newtab page because those get collapsed into one.
[Describe test coverage new/current, TBPL]: Adds tests for what should be consolidated into a single tile or not with existing tests updated from eTLD+1 to full host.
[Risks and why]: Small tweak from eTLD+1 to whole host, and would uplift after it bakes on m-c.
[String/UUID change made/needed]: none

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29d70a643e65

Comment 17

[Ed Lee :Mardak]

http://hg.mozilla.org/releases/mozilla-aurora/rev/111405b7a28a

Comment 18

[Cornel Ionce [:noni] [Hubs QA]]

Verified fixed on Windows 7 64bit, Mac OS X 10.9 and Ubuntu 14.04 using Firefox 34.0a1 Nightly (build ID: 20140902030202) and Firefox 33.0a2 Aurora (build ID: 20140902004002).