1045782 - Existing URLs in the See Also field should not throw an error when the bug is displayed

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Frédéric Buclin]

If you e.g. add a URL in the See Also field which follows a regexp defined in the MoreBugUrl extension and you later disable this extension, all bugs having such URLs become unreadable and an error is thrown instead, for instance:

  undef error - Can't locate Bugzilla/Extension/MoreBugUrl/RT.pm in @INC


Instead of throwing this error, existing URLs shouldn't be validated and so no error should be thrown. You should only be forbidden to add such URLs (unless you re-enable the extension so that the regexp is listed as valid again).

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 8702019 [details] [diff] [review]
patch, v1

Review of attachment 8702019 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

::: Bugzilla/BugUrl.pm
@@ +109,5 @@
>  
>      foreach my $object (@$objects) {
> +        eval "use " . $object->class;
> +        # If the class cannot be loaded, then we build a generic object.
> +        bless $object, $@ ? 'Bugzilla::BugUrl' : $object->class;

For a Perl newbie, it almost looks like $@ is a second argument to bless :)
Lets use parens to make it more readable maybe?

bless $object, ($@ ? 'Bugzilla::BugUrl' : $object->class);

Comment 3

[Frédéric Buclin]

To ssh://[e-mail]/bugzilla/bugzilla.git
   f709156..7829cc8  master -> master

To ssh://[e-mail]/bugzilla/bugzilla.git
   04004a6..f729352  5.0 -> 5.0