1046156 - "bind" entire AndroidLog module to a tag

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: "bind" entire AndroidLog module

It'd be handy to be able to "bind" the entire AndroidLog module to a tag, so you don't have to specify a tag each time you call one of its functions:

  let Log = Cu.import("resource://gre/modules/AndroidLog.jsm", {}).AndroidLog.bind("MyModule");
  Log.d("This is a debug message.");
  // Outputs "D/GeckoMyModule(#####): This is a debug message."

The "bind" function isn't Function.bind, as this is an object, not a function.  But it does for the object what Function.bind does for its individual functions.  So I figured it would make sense.  Commence bikeshedding at your leisure!

(I once implemented a preferences API that let you access prefs via both a root Prefs object and Prefs("branch") instances, which is roughly equivalent to what this provides; but that API was a bit subtle, too clever; this one seems better.)

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8464727 [details] [diff] [review]
patch v1: "bind" entire AndroidLog module

nice

Comment 2

[Myk Melez [:myk] [@mykmelez]]

https://hg.mozilla.org/integration/fx-team/rev/2cc8ef816748

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2cc8ef816748