Closed
Bug 1046761
Opened 10 years ago
Closed 10 years ago
youtube displays the browser context menu in e10s windows
Categories
(Firefox :: Menus, defect)
Tracking
()
VERIFIED
FIXED
Firefox 34
People
(Reporter: jimm, Assigned: billm)
References
Details
Attachments
(2 files)
36.42 KB,
image/png
|
Details | |
1.79 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
STR: 1) disable or uninstall flash (uninstall is best!) 2) open a new e10s window 3) visit youtube, view an html5 video 4) right click on the video In non-e10s windows, we get the youtube menu, in e10s windows, we get the youtube and browser context menus.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → wmccloskey
Updated•10 years ago
|
Updated•10 years ago
|
Component: General → Menus
Assignee | ||
Comment 2•10 years ago
|
||
Without e10s, we end up here: http://mxr.mozilla.org/mozilla-central/source/content/xul/content/src/nsXULPopupListener.cpp#105 That code checks the defaultPrevented property on the event and also some other stuff. In e10s, the event is generated in the context process and there's no XUL for the popup listener to be attached to, so we never hit that code. What it does for content seems to be pretty simple, so I just implemented it in a little JS.
Attachment #8477816 -
Flags: review?(felipc)
Updated•10 years ago
|
Attachment #8477816 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a50d9d53bdff
https://hg.mozilla.org/mozilla-central/rev/a50d9d53bdff
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 34
Updated•10 years ago
|
QA Whiteboard: [good first verify]
[bugday-20140910] This bug is fixed in Aurora 34.0a2 (buildID 20140910004000). Please set status-firefox34 to verified for me ;)
Comment 6•10 years ago
|
||
Thanks kenkon :) Marking this as verified based on comment 5.
Status: RESOLVED → VERIFIED
status-firefox34:
--- → verified
You need to log in
before you can comment on or make changes to this bug.
Description
•