1047131 - enable "user story" field on all products

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Jean Gong :jgong]

A couple of bugs filed but upon edit, bugzilla doesn't show the user story field for Product enter user story. 2 bug

https://bugzilla.mozilla.org/show_bug.cgi?id=1010743

https://bugzilla.mozilla.org/show_bug.cgi?id=865789

Comment 1

[Jean Gong :jgong]

Even for this bug itself.  When I edit this bug I don't see the user story field.

Comment 2

[Jean Gong :jgong]

It seems like when this original request was implemented Bug 963793  fix to have user story field available on bug creation.  The user story field was make available only to bugs filed under the Product category for Firefox OS. All the other categories for Core, Firefox, Firefox for Android, Firefox for Metro, Marketplace etc.. do not show the user story field upon bug creation.  You would need to make the user story field available for all these other product categories.

Comment 3

[David Lawrence [:dkl]]

Attachment: 1047131_1.patch

Comment 4

[Jean Gong :jgong]

(In reply to David Lawrence [:dkl] from comment #3)
> Created attachment 8466395 [details] [diff] [review]
> 1047131_1.patch

Can you let me know when this fix will be pushed to production?

Comment 5

[:glob ✱]

Comment on attachment 8466395 [details] [diff] [review]
1047131_1.patch

Review of attachment 8466395 [details] [diff] [review]:
-----------------------------------------------------------------

the user-story field isn't visible on enter_bug for products with an empty exclude-components list (i suggest restoring the block at the start of toggleUserStory and negating the logic).

::: extensions/UserStory/Extension.pm
@@ +43,5 @@
> +            }
> +            else {
> +                # If we are in enter_bug and there are specific exclude components,
> +                # we show the field as it will be filtered out in the template
> +                $self->{user_story_exclude_components} = $exclude_components;

as $exclude_components is always an empty array at this point there's no need to reference it here, or declare it outside of the if() block

Comment 6

[David Lawrence [:dkl]]

Attachment: 1047131_2.patch

Comment 7

[David Lawrence [:dkl]]

(In reply to Jean Gong from comment #4)
> Can you let me know when this fix will be pushed to production?

We are currently reviewing the second revision of this change so it will most likely be next
week's push that will contain the change if no other major fixes are needed. Pushes normally
happen around Tuesdays.

dkl

Comment 8

[:glob ✱]

Comment on attachment 8467804 [details] [diff] [review]
1047131_2.patch

Review of attachment 8467804 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

::: extensions/UserStory/lib/Constants.pm
@@ +22,5 @@
> +#   'Firefox OS' => [],
> +#   'Firefox'    => ['Developer Tools'],
> +use constant USER_STORY_EXCLUDE => {
> +    'Firefox'    => [],
> +    'Firefox OS' => ['Bluetooth']

i assume these exclusions are a result of debugging, and shouldn't be part of this patch.

Comment 9

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   b9b4791..ec10d05  master -> master

Comment 10

[David Lawrence [:dkl]]

(In reply to Byron Jones ‹:glob› from comment #8)
> > +    'Firefox'    => [],
> > +    'Firefox OS' => ['Bluetooth']
> 
> i assume these exclusions are a result of debugging, and shouldn't be part
> of this patch.

Yep :) Thanks for fixing and pushing it out.

dkl

Comment 11

[:glob ✱]

this is now live on production.