Closed Bug 1047393 Opened 10 years ago Closed 10 years ago

entering square brackets in location bar crashes [@ nsDefaultURIFixup::KeywordURIFixup(nsACString_internal const&, nsDefaultURIFixupInfo*, nsIInputStream**) ]

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Version:
34 Branch
Type:
defect
Priority:
Not set
Severity:
critical
Points:
2

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 34
Iteration:
34.2
Tracking Flags:
Tracking Status
firefox33 --- verified
firefox34 --- verified

People

(Reporter: yohann.jardin, Assigned: Gijs)

References

Details

(Keywords: crash, regression)

Crash Data

Attachments

(1 file)

fix crash in nsIURIFixup,
4.03 KB, patch
Gavin
: review+
Sylvestre
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 (Beta/Release)
Build ID: 20140731030206

Steps to reproduce:

Write [] in the Location bar and push Enter.


Actual results:

Firefox crash


Expected results:

A search on " [] " should have been launched.


Tried [, ] and {}, these 3 work fine.

Through mozregression :
Last good revision: 9b764e12796d
First bad revision: b97d42484365
Component: Untriaged → Location Bar
Confirmed against Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0 ID:20140801093819 CSet: 31f7e7f7d69b

bp-a5812d81-efb0-42b2-bf74-b85052140801
Blocks: 693808
Status: UNCONFIRMED → NEW
Crash Signature: [@ nsDefaultURIFixup::KeywordURIFixup(nsACString_internal const&, nsDefaultURIFixupInfo*, nsIInputStream**) ]
Ever confirmed: true
Keywords: regression
Summary: Square brackets in location bar → entering square brackets in location bar crashes [@ nsDefaultURIFixup::KeywordURIFixup(nsACString_internal const&, nsDefaultURIFixupInfo*, nsIInputStream**) ]
Flags: firefox-backlog+
Gavin, looks like more things that need to be fixed as soon as possible. :-\
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Iteration: --- → 34.2
Points: --- → 2
Flags: needinfo?(gavin.sharp)
Severity: normal → critical
Keywords: crash
OS: Windows 7 → All
Hardware: x86_64 → All
Actually, I have a patch already...
Iteration: 34.2 → 34.1

        Attachment #8467066 -
        Flags: review?(benjamin)

    
    

    
  
(this patch is based on top of the one for bug 1042519, but should not be hard to unbitrot if that somehow gets held up (which I believe to be unlikely, but hey))

        Attachment #8467066 -
        Flags: review?(benjamin) → review+
Flags: needinfo?(gavin.sharp)

    
    

    
  
Added to Iteration 34.1
QA Whiteboard: [qa?]

    
  
QA Whiteboard: [qa?] → [qa+]
Iteration: 34.1 → 34.2

    
    

    
  
remote:   https://hg.mozilla.org/integration/fx-team/rev/153960bf7476
Whiteboard: [fixed-in-fx-team]
QA Contact: alexandra.lucinet

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/153960bf7476
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
QA Contact: alexandra.lucinet → camelia.badau

    
    

    
  
Verified fixed on Windows 7 64bit, Windows 7 32bit, Windows 8.1, Ubuntu 13.10 32bit and Mac OSX 10.8.5 using latest Nightly 34.0a1 (buildID: 20140806030201).
Status: RESOLVED → VERIFIED
QA Whiteboard: [qa+] → [qa!]

    
    

    
  
Comment on attachment 8467066 [details] [diff] [review]
fix crash in nsIURIFixup,

Approval Request Comment
[Feature/regressing bug #]: 693808
[User impact if declined]: crash with certain location bar input
[Describe test coverage new/current, TBPL]: automated coverage, as well as manual verification
[Risks and why]: none
[String/UUID change made/needed]: none

        Attachment #8467066 -
        Flags: approval-mozilla-aurora?

    
  

          status-firefox33:
          --- → affected

          status-firefox34:
          --- → verified

        Attachment #8467066 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Flags: in-testsuite+

    
    

    
  
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.4 using latest Aurora 33.0a2 (buildID: 20140820004001).

          status-firefox33:
          fixed → verified

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: