1048772 - Incorrect value in "app.update.battery-threshold.plugged" and "app.update.battery-threshold.unplugged" are allowed

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Loli (:lolimartinezcr)]

Tested
Flame
2.1
Gecko-c60b44a
Gaia-ab8f1eb

Reproducible: 100%

STRs:
Modify "app.update.battery-threshold.plugged" and "app.update.battery-threshold.unplugged" in " build/config/common-settings.json" file and write an invalid value (for example: 866666666666666)

Actual result:
Allow invalid value in this properties.

Expected result:
*Not* Allow invalid value in this properties. (Valid values: 0 - 100)

Comment 1

[Salvador de la Puente González [:salva]]

As a continuation of bug 1048201, asking for blocking flag.

Comment 2

[Salvador de la Puente González [:salva]]

(In reply to Salvador de la Puente González [:salva] from comment #1)
> As a continuation of bug 1048201, asking for blocking flag.

Sorry, this is a continuation of bug 1034735.

Comment 3

[Salvador de la Puente González [:salva]]

Attachment: If the threshold exceeds the range [0, 100], the default values are taken instead.

Comment 4

[Jason Smith [:jsmith]]

Backlog since this is unrealistic for a partner to do with their build (i.e. setting the pref to an invalid value).

Comment 5

[Etienne Segonzac (:etienne)]

Comment on attachment 8467697 [details] [review]
If the threshold exceeds the range [0, 100], the default values are taken instead.

lgtm

Comment 6

[Salvador de la Puente González [:salva]]

master: e9dc30188b535fd5adb0a47fb9d72d188c9c1bc6

Comment 7

[Loli (:lolimartinezcr)]

Tested and working
Flame
2.1
Gecko-d5a4ba9
Gaia-80a41e0