Closed
Bug 1048827
Opened 10 years ago
Closed 10 years ago
[spartacus] REAUTH timeout can be shown post a success re-auth.
Categories
(Marketplace Graveyard :: Payments/Refunds, defect, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
2014-08-12
People
(Reporter: scolville, Assigned: scolville)
Details
(Whiteboard: [qa-])
If the timeout fires because the user takes a long time to re-auth the user sees the REAUTH_TIMEOUT message briefly before the handlePersonaLogin event fires. This is probably for the duration that the verification takes. To fix this we probably just need to add a app.error.close() in the handlePersonaLogin handler.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → scolville
Assignee | ||
Comment 1•10 years ago
|
||
https://github.com/mozilla/spartacus/commit/ccfd5adfce50e76c052c2e011335e44842cac8ae
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2014-08-12
Assignee | ||
Updated•10 years ago
|
Priority: -- → P3
Assignee | ||
Comment 2•10 years ago
|
||
This worked but then the sign-in window was also revealed. So instead of the app.error.close() we need to show a throbber which will close the error *and* show a throbber whilst the re-verification process happens.
Assignee | ||
Updated•10 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 3•10 years ago
|
||
s/sign-in window/sign-in view/
Assignee | ||
Comment 4•10 years ago
|
||
https://github.com/mozilla/spartacus/commit/f5f200fd2874c77c838f99173560829498ab2c23
Status: REOPENED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•