1048867 - party.webmaker.org/resources has a wrong page linked for "Register your event"

Status: RESOLVED FIXED

(Webmaker Graveyard :: Maker Party, defect)

Description

[Akshay S Dinesh]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140715214327

Steps to reproduce:

Go to http://party.webmaker.org/resources
On the big banner, there's a register your event link. Click on it.


Actual results:

Went to getting started resources


Expected results:

Should have gone to events.webmaker.org

Comment 1

[Cassie McDaniel [:cassiemc]]

Mavis, Akshay was wondering where the code was for this page so he can help fix it. Can you point him in the right direction?

I think this page could link straight to https://events.webmaker.org/#!/add (bypassing the events landing page).

Comment 2

[Mavis Ou [:mavis]]

Hey Akshay,

Thanks for reporting this issue.  You can find the corresponding code in  makerparty / views / resources.html around line 13.  https://github.com/mozilla/makerparty/blob/develop/views/resources.html#L13 

Let me know if you need more info :)

Mavis

Comment 3

[Erika Drushka]

Hey Cassie, 

I'd prefer that links always go to the events landing page, and never directly to  https://events.webmaker.org/#!/add because if you're not logged in, that page just gives you a login warning (and if you don't have an account you have to go through the entire Persona rigamarole).

Comment 4

[Akshay S Dinesh]

Hi Mavis!
I've changed that line and made a pull request
https://github.com/mozilla/makerparty/pull/54

Comment 5

[Jon Buckley [:jbuck]]

Attachment: https://github.com/mozilla/makerparty/pull/54

Comment 6

[Jon Buckley [:jbuck]]

Merged https://github.com/asdofindia/makerparty/commit/82864901cf956557ceceb57845212731809211ec into develop