1049031 - Create global configuration file for Gaia performance testing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::PerformanceTest, defect, P2)

Description

[:Eli Perelman]

Gaia performance tests do not have a unified file for sharing configuration or constant data. Adding an INI file to the gaia/tests/performance directory and including an easy mechanism for consumption would improve maintenance.

Comment 1

[:Eli Perelman]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files

First pass at implementing a global mechanism for holding performance testing utilities and configuration. Obviously this is a good-sized change with a bit of refactoring to take advantage of the new configuration and utilities. Also the format of the config file is open for discussion as well, I'd be happy to explain my logic behind this. :)

Comment 2

[:Eli Perelman]

Also, I've tested this locally using:

APP=settings RUNS=10 make test-perf
VERBOSE=1 APP=communications/dialer make test-perf
APP=email RUNS=1 make test-perf

All tests ran fine with no errors, and all environment variables were recognized and respected.

Comment 3

[:Eli Perelman]

Hub, just a note that the "goals" config section is just a placeholder and will be replaced with whatever data structure you deem fit for consumption.

Comment 4

[Hubert Figuiere [:hub]]

I did comment on the PR.

Comment 5

[:Eli Perelman]

PR updated with comments addressed.

Comment 6

[Hubert Figuiere [:hub]]

Comment on attachment 8468160 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/22545/files

Ship it !

(you ran the test after these changes, didn't you?)

Comment 7

[:Eli Perelman]

Thanks Hub! And yes, I ran the same command set as before to be sure.

Comment 8

[Hubert Figuiere [:hub]]

Merged
https://github.com/mozilla-b2g/gaia/commit/c49a3bab7caaee18d830448820f0f7082622b450