1049082 - Page markup for the watch notification message differs between dev and staging/prod

Status: NEW

(Websites :: wiki.mozilla.org, defect)

Description

[Bob Silverberg [:bsilverberg]]

One of our automated tests for the wiki has started failing when run against dev [1] because the markup differs between dev and stage [2] for the message that is displayed when watching and unwatching a page. Perhaps this difference stems from the two sites running different versions of MediaWiki? I would like to resolve this issue and get the test passing on both dev and staging again, but I am not sure how to best address it.

Is it expected that stage will be updated to have similar behaviour to dev in the near future?

[1] https://wiki-dev.allizom.org/
[2] https://wiki.allizom.org/

Comment 1

[Bob Silverberg [:bsilverberg]]

The same question stands for prod as well, as we run our tests on all three environments.

Comment 2

[Bob Silverberg [:bsilverberg]]

For future reference, the change that needs to be made to support the markup on dev is in /pages/watch_page.py and is:

-    _watchlist_message_locator = (By.CSS_SELECTOR, 'div.mw-js-message-ajaxwatch > p')
+    _watchlist_message_locator = (By.CSS_SELECTOR, 'div.mw-notification-tag-watch-self')

Comment 3

[Christie Koehler [:ckoehler]]

We're in the middle of upgrading Mozilla Wiki to the most current version of Mediawiki (1.23 branch). Dev has been updated to 1.23 and we're testing it now. Stage and production will be made to match Dev once we've completed upgrading and testing Dev. 

Also note that as part of this upgrade, we'll be changing the default theme of the wiki to Vector (from GMO). This might change some of the rendered css which might affect your tests.

Comment 4

[Bob Silverberg [:bsilverberg]]

Thanks for the update :ckoehler :)

I will leave this bug open as a reminder to update the test when the changes make it to staging and production.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Comment 6

[Spike, UTC+1, spike on Matrix]

Not sure if this was ever resolved or not - but we are currently trying to migrate from mediawiki version 1.27 to version 1.31 (and then probably 1.35 which is due to be released in August 2020).

Adding self as assignee to keep this bug visible.

Spike