1049596 - The compositor should not crash if applying a mask layer fails

Status: VERIFIED FIXED

(Core :: Graphics: Layers, defect)

Description

[Nicolas Silva [:nical]]

This is a followup from bug 1043426 where the patch got reviewed (but bounced on inbound)

try push with the patch fixed: https://tbpl.mozilla.org/?tree=Try&rev=ebc58d4d57dd

Comment 1

[Nicolas Silva [:nical]]

Attachment: Don't crash when failing to apply a mask (carry r=bas)

Comment 2

[Nicolas Silva [:nical]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0bc9fd5d0476

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

This may be affecting the high number of crashes still on Nightly that seem to be related to bug 1043426.

Comment 4

[Nicolas Silva [:nical]]

https://hg.mozilla.org/mozilla-central/rev/0bc9fd5d0476

my bad I put the wrong bug # in the commit.

This bug is closed now.

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Noting I can't verify this yet as this is still a top crashing signature on Nightly. 

Reports from last 3 days: https://crash-stats.mozilla.com/report/list?signature=mozilla%3A%3Alayers%3A%3ACompositorD3D11%3A%3ADrawQuad%28mozilla%3A%3Agfx%3A%3ARectTyped%3Cmozilla%3A%3Agfx%3A%3AUnknownUnits%3E+const%26%2C+mozilla%3A%3Agfx%3A%3ARectTyped%3Cmozilla%3A%3Agfx%3A%3AUnknownUnits%3E+const%26%2C+mozilla%3A%3Alayers%3A%3AEffectChain+const%26%2C+float%2C+mozilla%3A%3Agfx%3A%3AMatrix4x4+const%26%29&product=Firefox&query_type=contains&range_unit=days&process_type=any&version=Firefox%3A34.0a1&hang_type=any&date=2014-08-18+17%3A00%3A00&range_value=3#tab-table

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

No crashes past 2014081703. Verifying based on crash-stats.