1049882 - SeaMonkey Linux debug build error: multiple definition of `std::ctype<char>::_M_widen_init() const'

Status: RESOLVED INCOMPLETE

(SeaMonkey :: Build Config, defect)

Description

[Frank Wein [:mcsmurf]]

From IRC, the SeaMonkey comm-beta Linux32 debug build currently fails with this error:
builds/slave/c-beta-lnx-dbg/build/objdir/mozilla/_virtualenv/bin/python /builds/slave/c-beta-lnx-dbg/build/mozilla/config/expandlibs_exec.py --depend .deps/elfhack.pp --target elfhack -- /tools/gcc-4.7.3-0moz1/bin/g++ -o elfhack -gdwarf-2 -std=gnu++0x -MD -MP -MF .deps/elfhack.pp -static-libstdc++ host_elf.o host_elfhack.o ../../../build/unix/stdc++compat/libhost_stdc++compat.a
Executing:
/tools/gcc-4.7.3-0moz1/bin/g++ -o elfhack -gdwarf-2 -std=gnu++0x -MD -MP -MF .deps/elfhack.pp -static-libstdc++ host_elf.o host_elfhack.o ../stdc++compat/libhost_stdc++compat.a/tools/gcc-4.7.3-0moz1/lib/gcc/i686-pc-linux-gnu/4.7.3/../../../libstdc++.a(ctype.o): In function `std::ctype<char>::_M_widen_init() const':(.text._ZNKSt5ctypeIcE13_M_widen_initEv+0x0): multiple definition of `std::ctype<char>::_M_widen_init() const'
../stdc++compat/libhost_stdc++compat.a(host_stdc++compat.o):/builds/slave/c-beta-lnx-dbg/build/mozilla/build/unix/stdc++compat/stdc++compat.cpp:140: first defined here
collect2: error: ld returned 1 exit status

Comment 1

[Frank Wein [:mcsmurf]]

See also Bug 650467, even though that bug is already a bit older. I think we need to remove 
    line 17 -- export LDFLAGS="-static-libstdc++"
    line 18 -- export HOST_LDFLAGS="-static-libstdc++"

from the mozconfig and instead add
ac_add_options --enable-stdcxx-compat

Comment 2

[Frank Wein [:mcsmurf]]

Attachment: Patch for comm-beta

Basically the same as in Bug 904485
. "$topsrcdir/build/mozconfig.common"

already adds
ac_add_options --enable-stdcxx-compat

so only need to remove the old LDFLAGS.

Comment 3

[Frank Wein [:mcsmurf]]

Comment on attachment 8468792 [details] [diff] [review]
Patch for comm-beta

Pushed with approval and pending r via IRC: https://hg.mozilla.org/releases/comm-beta/rev/d5d0a72efd48

Comment 4

[Frank Wein [:mcsmurf]]

Attachment: Additional patch

Noticed this mozconfig file also needs the same fix.

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 8468840 [details] [diff] [review]
Additional patch

Also pushed: https://hg.mozilla.org/releases/comm-beta/rev/3f6edbb03b16

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8468792 [details] [diff] [review]
Patch for comm-beta

Review of attachment 8468792 [details] [diff] [review]:
-----------------------------------------------------------------

inferred a=me for necessary cross train landings

Comment 7

[Justin Wood (:Callek)]

Comment on attachment 8468840 [details] [diff] [review]
Additional patch

Review of attachment 8468840 [details] [diff] [review]:
-----------------------------------------------------------------

inferred a=me for necessary cross-train landings

Comment 8

[Frank-Rainer Grahl (:frg)]

in tree configs are no longer used and anre being redone for future 2.53 and up builds in bug 1687385