Closed Bug 1049967 Opened 10 years ago Closed 10 years ago

Yandex Elements add-on doesn't revert safe browsing (and other) prefs on uninstall

Categories

(WebExtensions :: General, defect)

Product:
WebExtensions
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kmag, Unassigned)

References

Details

I installed this from http://element.yandex.ru/

It prompts to change the search engine and homepage on install. It doesn't violate any policies here, but on uninstall, it does not revert the changes.

More pressing, though, is that it changes safe browsing preferences without prompting, and does not revert those changes on uninstall. The changes also result in breakage, as in bug 1048996.

ID: yasearch@yandex.ru
I'm trying to get in touch with Yandex.
Did you manage to contact them?
Flags: needinfo?(jorge)
(In reply to Dave Garrett from comment #2)
> It's also highly correlated with startup hangs:
> http://robertovitillo.com/2014/10/07/using-ml-to-correlate-add-ons-to-
> performance-bottlenecks/

It also seems to impact shutdown timings: http://robertovitillo.com/2014/10/16/correlating-add-ons-to-slow-shutdown-times/
We had a brief discussion about it, but the new performance issues make this a more serious problem. I'm bringing this discussion up again.
Flags: needinfo?(jorge)
The upcoming release 8.7.1 reverts the safe browsing pref on uninstall, other prefs will be fixed in the next release.  I've created bug 1094618 for the performance issues to separate that from the safe browsing pref issue.
Summary: Blocklist Yandex Elements add-on → Yandex Elements add-on doesn't revert safe browsing (and other) prefs on uninstall
Depends on: 1094596
Just landed the latest repack in partner builds in bug 1094596, do to the large size of the patch it is only a cursory review.  I've verified that the safe browsing pref is reverted on uninstall with this version (Yandex Elements 8.7.1).  http://element.yandex.ru/ still has 8.7.0, I expect that will be updated for fx34.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This is a blocklisting bug, so it's not FIXED as it's not blocklisted. Moving to TE instead.
Component: Blocklisting → Add-ons
Product: addons.mozilla.org → Tech Evangelism
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
You need to log in before you can comment on or make changes to this bug.