Closed
Bug 1050174
Opened 10 years ago
Closed 10 years ago
[Bluetooth] Port bug 992206 to bluetooth2
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: tzimmermann, Assigned: tzimmermann)
References
Details
Attachments
(12 files)
|
3.63 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
2.98 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
5.95 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
3.61 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
2.35 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
2.35 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
1.81 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
7.39 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
5.44 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
1.96 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
2.31 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
|
8.14 KB,
patch
|
ben.tian
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8475758 -
Flags: review?(btian)
|
|
Assignee | |
Comment 2•10 years ago
|
||
Attachment #8475759 -
Flags: review?(btian)
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8475760 -
Flags: review?(btian)
|
|
Assignee | |
Comment 4•10 years ago
|
||
Attachment #8475761 -
Flags: review?(btian)
|
|
Assignee | |
Comment 5•10 years ago
|
||
Attachment #8475763 -
Flags: review?(btian)
|
|
Assignee | |
Comment 6•10 years ago
|
||
Attachment #8475764 -
Flags: review?(btian)
|
|
Assignee | |
Comment 7•10 years ago
|
||
Attachment #8475767 -
Flags: review?(btian)
|
|
Assignee | |
Comment 8•10 years ago
|
||
Attachment #8475769 -
Flags: review?(btian)
|
|
Assignee | |
Comment 9•10 years ago
|
||
Attachment #8475771 -
Flags: review?(btian)
|
|
Assignee | |
Comment 10•10 years ago
|
||
Attachment #8475773 -
Flags: review?(btian)
|
|
Assignee | |
Comment 11•10 years ago
|
||
Attachment #8475775 -
Flags: review?(btian)
|
|
Assignee | |
Comment 12•10 years ago
|
||
Attachment #8475777 -
Flags: review?(btian)
|
|
Assignee | |
Comment 13•10 years ago
|
||
Hi Ben, This patchset replaces code of BluetoothSocket with a generic implementation. It's a lot of patches, but often only little change per patch.
|
||
Comment 14•10 years ago
|
||
Comment on attachment 8475760 [details] [diff] [review] [03] Bug 1050174: Use |SocketIORunnable| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475760 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475760 -
Flags: review?(btian) → review+
|
|
||
Comment 15•10 years ago
|
||
Comment on attachment 8475761 [details] [diff] [review] [04] Bug 1050174: Use |SocketIOEventRunnable| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475761 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475761 -
Flags: review?(btian) → review+
|
|
||
Comment 16•10 years ago
|
||
Comment on attachment 8475763 [details] [diff] [review] [05] Bug 1050174: Use |SocketIOReceiveRunnable| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475763 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475763 -
Flags: review?(btian) → review+
|
|
||
Comment 17•10 years ago
|
||
Comment on attachment 8475764 [details] [diff] [review] [06] Bug 1050174: Use |SocketIORequestClosingRunnable| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475764 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475764 -
Flags: review?(btian) → review+
|
|
||
Comment 18•10 years ago
|
||
Comment on attachment 8475767 [details] [diff] [review] [07] Bug 1050174: Use |SocketIODeleteInstanceRunnable| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475767 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475767 -
Flags: review?(btian) → review+
|
|
||
Comment 19•10 years ago
|
||
Comment on attachment 8475769 [details] [diff] [review] [08] Bug 1050174: Use |SocketIOBase| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475769 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475769 -
Flags: review?(btian) → review+
|
|
||
Comment 20•10 years ago
|
||
Comment on attachment 8475775 [details] [diff] [review] [11] Bug 1050174: Use |SocketIOShutdownTask| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475775 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475775 -
Flags: review?(btian) → review+
|
|
||
Comment 21•10 years ago
|
||
Comment on attachment 8475773 [details] [diff] [review] [10] Bug 1050174: Use |SocketIOSendTask| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475773 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475773 -
Flags: review?(btian) → review+
|
|
||
Comment 22•10 years ago
|
||
Comment on attachment 8475771 [details] [diff] [review] [09] Bug 1050174: Use |SocketIOTask| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475771 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475771 -
Flags: review?(btian) → review+
|
|
||
Comment 23•10 years ago
|
||
Comment on attachment 8475777 [details] [diff] [review] [12] Bug 1050174: Cleanup interface of |BluetoothSocket| (under bluetoth2/) Review of attachment 8475777 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475777 -
Flags: review?(btian) → review+
|
|
||
Comment 24•10 years ago
|
||
Comment on attachment 8475759 [details] [diff] [review] [02] Bug 1050174: Use |SocketConsumerBase| for Bluetooth sockets (under bluetooth2/) Review of attachment 8475759 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8475759 -
Flags: review?(btian) → review+
|
|
||
Comment 25•10 years ago
|
||
Comment on attachment 8475758 [details] [diff] [review] [01] Bug 1050174: Cleanup fields in |DroidSocketImpl| (under bluetooth2/) Review of attachment 8475758 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Thanks for the effort!
Attachment #8475758 -
Flags: review?(btian) → review+
|
|
Assignee | |
Comment 26•10 years ago
|
||
Thanks a lot :) https://hg.mozilla.org/integration/b2g-inbound/rev/24c41436fb53 https://hg.mozilla.org/integration/b2g-inbound/rev/b7d712b9f963 https://hg.mozilla.org/integration/b2g-inbound/rev/499650fa344f https://hg.mozilla.org/integration/b2g-inbound/rev/85aebdd03a8b https://hg.mozilla.org/integration/b2g-inbound/rev/c909ea15ad43 https://hg.mozilla.org/integration/b2g-inbound/rev/d65fe70828c1 https://hg.mozilla.org/integration/b2g-inbound/rev/364c67cefa5e https://hg.mozilla.org/integration/b2g-inbound/rev/8e834c423377 https://hg.mozilla.org/integration/b2g-inbound/rev/d18894e0c89b https://hg.mozilla.org/integration/b2g-inbound/rev/c035b2ebaed1 https://hg.mozilla.org/integration/b2g-inbound/rev/ca2333ff39a8 https://hg.mozilla.org/integration/b2g-inbound/rev/3fdbeebfcbf2 https://tbpl.mozilla.org/?tree=B2g-Inbound&rev=24c41436fb53
|
||
Comment 27•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/3fdbeebfcbf2 https://hg.mozilla.org/mozilla-central/rev/ca2333ff39a8 https://hg.mozilla.org/mozilla-central/rev/c035b2ebaed1 https://hg.mozilla.org/mozilla-central/rev/d18894e0c89b https://hg.mozilla.org/mozilla-central/rev/8e834c423377 https://hg.mozilla.org/mozilla-central/rev/364c67cefa5e https://hg.mozilla.org/mozilla-central/rev/d65fe70828c1 https://hg.mozilla.org/mozilla-central/rev/c909ea15ad43 https://hg.mozilla.org/mozilla-central/rev/85aebdd03a8b https://hg.mozilla.org/mozilla-central/rev/499650fa344f https://hg.mozilla.org/mozilla-central/rev/b7d712b9f963 https://hg.mozilla.org/mozilla-central/rev/24c41436fb53
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•