1050185 - Make ThreadStackHelper::FillThreadContext Valgrind-friendly

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Julian Seward [:jseward]]

ThreadStackHelper::FillThreadContext takes a snapshot of a thread's
stack, which may later get presented to Breakpad in the same process
for unwinding, at least as part of the hang detection/reporting
machinery.  Because the stack may contain uninitialised holes, this
causes Valgrind to complain later when Breakpad processes the stack.

A simple solution is to mark the copied data as initialised.  This
has no performance or functionality effects for production builds.

Comment 1

[Julian Seward [:jseward]]

Attachment: Fix

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8469169 [details] [diff] [review]
Fix

Review of attachment 8469169 [details] [diff] [review]:
-----------------------------------------------------------------

Thank you!

Comment 3

[Julian Seward [:jseward]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5f3d60e703ba

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/5f3d60e703ba