1050652 - Implement GetEvictionOffset for WebM reader.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Comment 1

[Matthew Gregan [:kinetik]]

Attachment: Implement GetEvictionOffset for WebM reader.

Comment 2

[Matthew Gregan [:kinetik]]

Attachment: Implement GetEvictionOffset for WebM reader. v2

Fix a silly compile error. :-|

Comment 3

[cajbir (:cajbir)]

Comment on attachment 8469861 [details] [diff] [review]
Implement GetEvictionOffset for WebM reader. v2

Review of attachment 8469861 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/webm/WebMBufferedParser.h
@@ +199,5 @@
>  
>    void NotifyDataArrived(const char* aBuffer, uint32_t aLength, int64_t aOffset);
>    bool CalculateBufferedForRange(int64_t aStartOffset, int64_t aEndOffset,
>                                   uint64_t* aStartTime, uint64_t* aEndTime);
> +  bool GetOffsetForTime(uint64_t aTime, int64_t* aOffset, bool aSyncPoint);

Remove the boolean parameter and make it an enum of some sort. Add a comment explaining what it is.

Comment 4

[Matthew Gregan [:kinetik]]

Attachment: Implement GetEvictionOffset for WebM reader. v2

Address review comments, carry forward r+

Comment 5

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1150a58d8b3a

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/1150a58d8b3a

Comment 7

[cajbir (:cajbir)]

This patch breaks seeking on the youtube demo page.  If I revert this patch then seeking works again. I've raised bug 1054970 for this.

Comment 8

[avada]

Attachment: yt seekbar

Is this caused by this bug?

Comment 9

[avada]

Ugh. Meant to post it in Bug 1054970.

Comment 10

[Matthew Gregan [:kinetik]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/59cc2ccbdd64

Comment 11

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/59cc2ccbdd64