1050683 - UnifiedComplete is missing nsIAutoCompleteSearchDescriptor

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Looks like I forgot to add it, it's a very trivial oneline patch.

Marco, could you please add this to the current iteration? It will take just a few minutes. (yes, I know about the cap, no worries)

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v1

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/fx-team/rev/c61532028ee4

Comment 3

[Ed Morley [:emorley]]

Backed out for failures like:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45541626&tree=Fx-Team

remote:   https://hg.mozilla.org/integration/fx-team/rev/17408fd769e2

Comment 4

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

bah, clearly something is funky with the test

Comment 5

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: patch v2

This has not been as trivial as I was expecting, but a good companion for a Friday night.

The test hit a race condition that cause a search to cancel itself, good to fix it. On the positive side this means the patch is doing what I was expecting, thus remove the urlbar delay.

It's currently running on Try.

https://tbpl.mozilla.org/?tree=Try&rev=8dd1240eeff

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8470343 [details] [diff] [review]
patch v2

Review of attachment 8470343 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/integration/fx-team/rev/eae2c3cb8a19

Comment 8

[Nigel Babu [:nigelb]]

https://hg.mozilla.org/mozilla-central/rev/eae2c3cb8a19