1051754 - B2G NFC: Add marionette test for peer.sendFile

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Currently we don't have tests for peer.sendFile, we should write one.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8470756 [details] [diff] [review]
Patch

Review of attachment 8470756 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/nfc/tests/marionette/test_nfc_peer_sendFile.js
@@ +16,5 @@
> +  NCI.deactivate().then(() => toggleNFC(false)).then(runNextTest);
> +}
> +
> +function testSendFile() {
> +  nfc.onpeerready = function (evt) {

Nits. space after function, here and below

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

addressed nits.

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/52fc270e59ad

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/52fc270e59ad

Comment 6

[Ed Morley [:emorley]]

Reverted for intermittent test failures:
https://tbpl.mozilla.org/php/getParsedLog.php?id=45922784&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/b2g-inbound/rev/dd1174deb44c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Merge of backout:
https://hg.mozilla.org/mozilla-central/rev/dd1174deb44c

Comment 8

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

run try again, and the tree is green.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=6656acda1059

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dbbb19ff9525

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/dbbb19ff9525