1051760 - Assertion failure: !vp.isMagic(), at jsobj.cpp:4600

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase asserts on mozilla-central revision a9b43778f0c2 (run with --no-threads --fuzzing-safe --ion-eager):


function TestCase(n) {
  this.name = n;
}
function newFunc(x) { new Function(x)(); };
newFunc('new TestCase("x", TestCase("x") );');
function test() {
eval("var { [arguments] : y }  = name;");
} test();

Comment 1

[Christian Holler (:decoder)]

Attachment: [crash-signature] Machine-readable crash signature

Comment 2

[Christian Holler (:decoder)]

JSBugMon: Bisection requested, result:
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/7079b7552946
user:        Guptha Rajagopal
date:        Fri Aug 08 09:15:00 2014 -0400
summary:     Bug 924688 - Implement ES6 computed property names. r=jorendorff

This iteration took 591.676 seconds to run.

Comment 3

[Christian Holler (:decoder)]

Needinfo from Jason based on comment 2. Jason, can you work with the patch contributor here to fix this? Thanks!

Comment 4

[Jason Orendorff [:jorendorff]]

Simpler:

function test() {
    eval("var { [arguments] : y }  = {};");
}
test();

I'm not sure what this should do, honestly. Not crash.

Comment 5

[Jason Orendorff [:jorendorff]]

Attachment: Fix "Assertion failure: !vp.isMagic(), at jsobj.cpp:4600" with arguments, direct eval, and a destructuring declaration

Comment 6

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/de8214005a4a

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de8214005a4a