1051803 - [Loop] The notification is not a sound or a vibration, (it can't be heared or felt) if the device is in vibration mode when the call or video call is establishing.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Javier de Prado]

Device: fireE
Version: d9507c2

STR
1.- Put Device B in vibration mode. 
2.- Device A makes a call to device B.


ACTUAL RESULT
1.- No sound is heard or vibration is felt, when the call is establishing.

EXPECTED RESULT
According to the test case, the notification should be a vibration.

Comment 1

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue still occurs on the latest 2.0 build with the v165 KK base. The phone does not vibrate when receiving a call.

Environmental Variables:
Device: Flame 2.0
BuildID: 20140819030000
Gaia: 287a2c725a5c14e5dc1d48e3158ffc79c7d1ea33
Gecko: 6329352ca531b977979451e77e5862af485388b2
Version: 32.0 (2.0) 
Firmware Version: v165
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0


Loop version: 32219a2

Comment 2

[Maria Angeles Oteo (:oteo)]

If the device has the vibration mode activated, it should vibrate when an incoming call is received.

Comment 3

[Maria Angeles Oteo (:oteo)]

After talking with Product team and for this first Loop mobile client version, we would try to include the vibration setting into the Loop mobile app settings. 

Vicky, Pau can you help us with this issue?

Comment 4

[Carmen Jimenez Cabezas]

Attachment: V1 Proposed patch

Comment 5

[Carmen Jimenez Cabezas]

Attachment: screenshot proposed setting

Comment 6

[Pau Masiá [:Pau]]

It works for me. Thanks!

Comment 7

[Victoria Gerchinhoren [:vicky]]

Looks ok.

Comment 8

[Pau Masiá [:Pau]]

Carmen, could you upload a screenshot so I can review it better than the code, please? ;)

Comment 9

[Pau Masiá [:Pau]]

Sorry, can you ask Vicky for review better? Thanks.

Comment 10

[Borja Salguero [:borjasalguero]]

Comment on attachment 8496270 [details] [review]
V1 Proposed patch

Some comments to address! Let me know when ready and I'll review it again. Thanks!

Comment 11

[Carmen Jimenez Cabezas]

Attachment: v2 screenshot proposed setting

Comment 12

[Borja Salguero [:borjasalguero]]

Comment on attachment 8496270 [details] [review]
V1 Proposed patch

Some changes still needed. We are quite close to have this sorted out!

Comment 13

[Carmen Jimenez Cabezas]

Attachment: v2 screenshot proposed setting - ES

Comment 14

[Borja Salguero [:borjasalguero]]

Comment on attachment 8496270 [details] [review]
V1 Proposed patch

We need to store & update just one object, not every setting as a separate entity. This will save a lot of lines of code and we will remove a source of error. Let me know when ready!

Comment 15

[Borja Salguero [:borjasalguero]]

Comment on attachment 8496270 [details] [review]
V1 Proposed patch

Thanks for the patch! Please rebase & merge!

Comment 16

[Carmen Jimenez Cabezas]

https://github.com/mozilla-b2g/firefoxos-loop-client/commit/0c338106adc7f056068db55b212ef6682c05ed8a

Comment 17

[Javier de Prado]

Loop version: dbe5fb3
Build version: Gecko-7107b06.Gaia-c1f6089
RAM: 512M


STR:
1.- Login loop app in Device-A and Device-B (check settings are in default mode -> vibrate mode ON)
2.- Open loop settings in device-B and disable vibrate mode.
3.- Instead of tapping "Done" button, kill loop app long tapping from home button.
4.- Make a call from Device-A to Device-B, and check that Device-B is not vibrating, and check that vibration mode in settings, is set to OFF.
5.- Enable vibration mode in Device-B, and kill again loop app long tapping from home button.
6.- Make a call from Device-A to Device-B

ACTUAL RESULT: Device-B is not vibrating and in loop setting vibration mode is enabled.

EXPECTED RESULT: Killing loop app without tapping "Done" button in loop settings, should change the vibration mode. (in the same way as in "default call mode" and "Camera")

Comment 18

[Carmen Jimenez Cabezas]

It isn't a vibration setting problem and it doesn't depend of how you close the setting panel (tapping "Done" button or killing loop).

Regardless the value that the settings have, if the loop app receives a call while it's closed, the incoming call always will use the back camera and won't vibrate because the call screen manager is launched before the settings have been initialized.

It isn't a vibration setting problem and it doesn't depend of how you close the setting panel (tapping "Done" button or killing loop).

Regardless the value that the settings have, if the loop app receives a call while it's closed, the incoming call ever will be with backCamera and vibrate off because the callScreenManager is launched before the settings have had time of initialize themselves.

I've opened the bug 1080756 for this issue.

Comment 19

[Carmen Jimenez Cabezas]

Resolved in bug 1080756

Comment 20

[Javier de Prado]

Verified on flame and fireE
Loop version: 2168965