Closed Bug 1052009 Opened 10 years ago Closed 10 years ago

Enable CloudSync in Nightly

Categories

(Cloud Services Graveyard :: cloudSync, defect)

Product:
Cloud Services Graveyard
Component:
cloudSync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox32 unaffected, firefox33 unaffected, firefox34+ fixed, firefox35 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla35
Tracking Flags:
Tracking Status
firefox32 --- unaffected
firefox33 --- unaffected
firefox34 + fixed
firefox35 --- fixed

People

(Reporter: rnewman, Assigned: akligman)

References

Details

Attachments

(2 files, 1 obsolete file)

0001-Bug-1052009-Enable-CloudSync-in-Nightly.patch
684 bytes, patch
akligman
: review+
lmandel
: approval-mozilla-aurora+
Details | Diff | Splinter Review
0002-Bug-1052009-Enable-CloudSync-in-Nightly.patch
1.75 KB, patch
Details | Diff | Splinter Review 
      No description provided.
Attached patch enable_cloudsync.patch (obsolete) — — Splinter Review 
Assignee: nobody → akligman
Status: NEW → ASSIGNED

        Attachment #8471333 -
        Flags: review?(rnewman)

    
    

    
  
Comment on attachment 8471333 [details] [diff] [review]
enable_cloudsync.patch

Over to a build peer.

        Attachment #8471333 -
        Flags: review?(rnewman) → review?(gps)

    
    

    
  
Comment on attachment 8471333 [details] [diff] [review]
enable_cloudsync.patch

Review of attachment 8471333 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is technically sound.

But r+ for enabling features is typically deferred to someone with knowledge of the feature and its implications. I know nothing about this feature and don't feel comfortable giving it a green light.

        Attachment #8471333 -
        Flags: review?(gps) → feedback+

    
    

    
  


  
Land before B#993584.

        Attachment #8471333 -
        Attachment is obsolete: true

        Attachment #8481448 -
        Flags: review+

    
  
Keywords: checkin-needed

    
    

    
  
Can we get a Try run for this and the other cloudsync bugs?
Flags: needinfo?(akligman)
Keywords: checkin-needed

    
    

    
  
This should not be checked in until all dependencies have landed. That's why it's a separate bug.
Whiteboard: [do not land until dependencies land]

    
    

    
  
https://tbpl.mozilla.org/?tree=Try&rev=f0128f81350f
Flags: needinfo?(akligman)

    
  
Keywords: checkin-needed

    
    

    
  
Hi Alan, so is this now ready to land ? Bug 993584 landed but the other dependency bugs here are open ?
Flags: needinfo?(akligman)
Keywords: checkin-needed

    
    

    
  
I'm investigating the tbpl failures you reported.
Flags: needinfo?(akligman)

    
  
Keywords: checkin-needed

    
    

    
  
Note: this should land after 1045046.

    
    

    
  
https://hg.mozilla.org/integration/fx-team/rev/4476fca7e5fe
Keywords: checkin-needed
Whiteboard: [do not land until dependencies land] → [do not land until dependencies land][fixed-in-fx-team]

    
    

    
  
sorry had to backout this change in https://tbpl.mozilla.org/?tree=Fx-Team&rev=1951712e6147 since one of this checkins seems to have caused https://tbpl.mozilla.org/php/getParsedLog.php?id=47669697&tree=Fx-Team
Whiteboard: [do not land until dependencies land][fixed-in-fx-team] → [do not land until dependencies land]

    
    

    
  
This enables cloudsync and causes new tests to run. I'm not seeing this failure in the other test runs I did. Investigating.

    
  
Keywords: checkin-needed
Whiteboard: [do not land until dependencies land]

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/f980055c8339
https://hg.mozilla.org/mozilla-central/rev/582c6bff081d
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 35

    
  
Component: Sync → cloudSync
Product: Firefox → Mozilla Services
Target Milestone: Firefox 35 → ---
Version: Trunk → unspecified

    
    

    
  
Comment on attachment 8481448 [details] [diff] [review]
0001-Bug-1052009-Enable-CloudSync-in-Nightly.patch

This enables the service in bug#993584.

Approval Request Comment
[Feature/regressing bug #]: n/a
[User impact if declined]: For a partner project that we have committed to delivering in 34
[Describe test coverage new/current, TBPL]:Basic test coverage for API, some mochitest coverage for UI events
[Risks and why]: Low impact, mostly new code; Unlikely to receive any input from our pre-release user populations as this requires a separate add-on that is not yet ready
[String/UUID change made/needed]: No string changes

        Attachment #8481448 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8481448 [details] [diff] [review]
0001-Bug-1052009-Enable-CloudSync-in-Nightly.patch

I've spoken with Alan about this feature and the need to ship it in 34. Aurora+

        Attachment #8481448 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

    
  
Product: Cloud Services → Cloud Services Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: