Open
Bug 1052141
Opened 10 years ago
Updated 2 years ago
Add a test that makes sure crashed GMP plugins are reported to the crash service
Categories
(Core :: WebRTC, defect, P4)
Core
WebRTC
Tracking
()
NEW
| backlog | webrtc/webaudio+ |
People
(Reporter: adw, Unassigned)
References
Details
Attachments
(1 file)
|
10.71 KB,
patch
|
Details | Diff | Splinter Review |
Bug 1009765 landed without a test that makes sure crashed GMP plugins are reported to the crash service. This patch, copied over from the other bug, adds adds one and makes related necessary changes, but it leaks a CondVar, GeckoChildProcessHost, and Mutex. Filing this in Core::WebRTC because that's where the test in this patch lives.
Flags: firefox-backlog+
|
||
Comment 2•10 years ago
|
||
In bug 1035056 I encountered this leak when plugins crashed while shutting down. I fixed it by ensuring that GeckoMediaPluginService::ReAddOnGMPThread() does not re-add a GMP clone if we're already shutting down. This is a different case (the GMP is not crashing while shutting down here, right?), but the cause could be something similar.
|
||
Updated•9 years ago
|
backlog: --- → webRTC+
Rank: 55
Priority: -- → P5
|
||
Comment 3•5 years ago
|
||
I think comment 2 tells us why this was leaking. It is probably a good idea to test this.
Rank: 55 → 35
Flags: needinfo?(rjesup)
Priority: P5 → P4
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•