1052464 - error when adding first account: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgAccountManager.defaultAccount]" mailInstrumentation.js in minst_postStateObject line 101

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thunderbird 34.0a1 20140723 and 31.0 on Windows 8.1

When creating a new (existing account) to Thunderbird, remote debugging shows the following error twice (twice, because it gets logged as error + dumped):

[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIMsgAccountManager.defaultAccount]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: resource://gre/modules/mailInstrumentation.js :: minst_postStateObject :: line 101"  data: no] errUtils.js:96

Reason: _postStateObject doesn't handle MailServices.accounts.accounts.length == 0 which is true when the SMTP server gets created (which has to run before the creation of the incoming account.)

Comment 1

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v1

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 8471593 [details] [diff] [review]
patch, v1

Review of attachment 8471593 [details] [diff] [review]:
-----------------------------------------------------------------

::: mail/base/modules/mailInstrumentation.js
@@ +99,5 @@
> +    // Getting defaultAccount will throw an exception if no account is set up.
> +    // This method runs for the smtp server before the account has been set up.
> +    if (MailServices.accounts.accounts.length == 0) {
> +      return;
> +    }

no need for the braces, and you can move this up to be first in the function

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: patch, v2, r=mkmelin

Comment 4

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/5e5314dec210